[lldb] Split up shared cache objc metadata extractor body #167761
Merged
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After my previous change (llvm#167579), the string exceeded 16380 single-byte characters. MSVC did not like this, so I'm splitting it up into two strings.
Member
|
@llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) ChangesAfter my previous change (#167579), the string exceeded 16380 single-byte characters. MSVC did not like this, so I'm splitting it up into two strings. Full diff: https://github.com/llvm/llvm-project/pull/167761.diff 1 Files Affected:
diff --git a/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp b/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
index 27a2c9e1d1dd9..83e39f37d8dcf 100644
--- a/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
+++ b/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
@@ -320,7 +320,7 @@ extern "C"
static const char *g_get_shared_cache_class_info_name =
"__lldb_apple_objc_v2_get_shared_cache_class_info";
-static const char *g_get_shared_cache_class_info_body = R"(
+static const char *g_get_shared_cache_class_info_definitions = R"(
extern "C"
{
@@ -411,6 +411,9 @@ struct ClassInfo
Class isa;
uint32_t hash;
} __attribute__((__packed__));
+)";
+
+static const char *g_get_shared_cache_class_info_body = R"(
uint32_t
__lldb_apple_objc_v2_get_shared_cache_class_info (void *objc_opt_ro_ptr,
@@ -1962,6 +1965,7 @@ AppleObjCRuntimeV2::SharedCacheClassInfoExtractor::
class_name_getter_function_name.AsCString(),
class_name_getter_function_name.AsCString());
+ shared_class_expression += g_get_shared_cache_class_info_definitions;
shared_class_expression += g_get_shared_cache_class_info_body;
auto utility_fn_or_error = exe_ctx.GetTargetRef().CreateUtilityFunction(
|
Member
Author
|
Landing to unbreak build |
bulbazord
added a commit
to bulbazord/llvm-project
that referenced
this pull request
Nov 12, 2025
After my previous change (llvm#167579), the string exceeded 16380 single-byte characters. MSVC did not like this, so I'm splitting it up into two strings. (cherry picked from commit 6806349)
git-crd
pushed a commit
to git-crd/crd-llvm-project
that referenced
this pull request
Nov 13, 2025
After my previous change (llvm#167579), the string exceeded 16380 single-byte characters. MSVC did not like this, so I'm splitting it up into two strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After my previous change (#167579), the string exceeded 16380 single-byte characters. MSVC did not like this, so I'm splitting it up into two strings.