-
Notifications
You must be signed in to change notification settings - Fork 15.2k
AMDGPU: Add baseline test for load-select to load select of pointer combine #167908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arsenm
merged 1 commit into
main
from
users/arsenm/amdgpu/baseline-test-load-select-combine
Nov 13, 2025
Merged
AMDGPU: Add baseline test for load-select to load select of pointer combine #167908
arsenm
merged 1 commit into
main
from
users/arsenm/amdgpu/baseline-test-load-select-combine
Nov 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
|
@llvm/pr-subscribers-llvm-selectiondag @llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) ChangesFull diff: https://github.com/llvm/llvm-project/pull/167908.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/AMDGPU/select-load-to-load-select-ptr-combine.ll b/llvm/test/CodeGen/AMDGPU/select-load-to-load-select-ptr-combine.ll
new file mode 100644
index 0000000000000..423fb7d52d3e3
--- /dev/null
+++ b/llvm/test/CodeGen/AMDGPU/select-load-to-load-select-ptr-combine.ll
@@ -0,0 +1,123 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 6
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 < %s | FileCheck %s
+
+define i32 @select_load_i32_p0(i1 %cond, ptr %a, ptr %b) {
+; CHECK-LABEL: select_load_i32_p0:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
+; CHECK-NEXT: v_and_b32_e32 v0, 1, v0
+; CHECK-NEXT: v_cmp_eq_u32_e32 vcc, 1, v0
+; CHECK-NEXT: v_cndmask_b32_e32 v2, v4, v2, vcc
+; CHECK-NEXT: v_cndmask_b32_e32 v1, v3, v1, vcc
+; CHECK-NEXT: flat_load_dword v0, v[1:2]
+; CHECK-NEXT: s_waitcnt vmcnt(0) lgkmcnt(0)
+; CHECK-NEXT: s_setpc_b64 s[30:31]
+ %ld0 = load i32, ptr %a
+ %ld1 = load i32, ptr %b
+ %select = select i1 %cond, i32 %ld0, i32 %ld1
+ ret i32 %select
+}
+
+define i32 @select_load_i32_p1(i1 %cond, ptr addrspace(1) %a, ptr addrspace(1) %b) {
+; CHECK-LABEL: select_load_i32_p1:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
+; CHECK-NEXT: global_load_dword v5, v[1:2], off
+; CHECK-NEXT: global_load_dword v6, v[3:4], off
+; CHECK-NEXT: v_and_b32_e32 v0, 1, v0
+; CHECK-NEXT: v_cmp_eq_u32_e32 vcc, 1, v0
+; CHECK-NEXT: s_waitcnt vmcnt(0)
+; CHECK-NEXT: v_cndmask_b32_e32 v0, v6, v5, vcc
+; CHECK-NEXT: s_setpc_b64 s[30:31]
+ %ld0 = load i32, ptr addrspace(1) %a
+ %ld1 = load i32, ptr addrspace(1) %b
+ %select = select i1 %cond, i32 %ld0, i32 %ld1
+ ret i32 %select
+}
+
+define i32 @select_load_i32_p3(i1 %cond, ptr addrspace(3) %a, ptr addrspace(3) %b) {
+; CHECK-LABEL: select_load_i32_p3:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
+; CHECK-NEXT: ds_read_b32 v1, v1
+; CHECK-NEXT: ds_read_b32 v2, v2
+; CHECK-NEXT: v_and_b32_e32 v0, 1, v0
+; CHECK-NEXT: v_cmp_eq_u32_e32 vcc, 1, v0
+; CHECK-NEXT: s_waitcnt lgkmcnt(0)
+; CHECK-NEXT: v_cndmask_b32_e32 v0, v2, v1, vcc
+; CHECK-NEXT: s_setpc_b64 s[30:31]
+ %ld0 = load i32, ptr addrspace(3) %a
+ %ld1 = load i32, ptr addrspace(3) %b
+ %select = select i1 %cond, i32 %ld0, i32 %ld1
+ ret i32 %select
+}
+
+define i32 @select_load_i32_p0_p1(i1 %cond, ptr %a, ptr addrspace(1) %b) {
+; CHECK-LABEL: select_load_i32_p0_p1:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
+; CHECK-NEXT: flat_load_dword v5, v[1:2]
+; CHECK-NEXT: global_load_dword v6, v[3:4], off
+; CHECK-NEXT: v_and_b32_e32 v0, 1, v0
+; CHECK-NEXT: v_cmp_eq_u32_e32 vcc, 1, v0
+; CHECK-NEXT: s_waitcnt vmcnt(0) lgkmcnt(0)
+; CHECK-NEXT: v_cndmask_b32_e32 v0, v6, v5, vcc
+; CHECK-NEXT: s_setpc_b64 s[30:31]
+ %ld0 = load i32, ptr %a
+ %ld1 = load i32, ptr addrspace(1) %b
+ %select = select i1 %cond, i32 %ld0, i32 %ld1
+ ret i32 %select
+}
+
+define i32 @select_load_i32_p1_p0(i1 %cond, ptr addrspace(1) %a, ptr %b) {
+; CHECK-LABEL: select_load_i32_p1_p0:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
+; CHECK-NEXT: global_load_dword v5, v[1:2], off
+; CHECK-NEXT: flat_load_dword v6, v[3:4]
+; CHECK-NEXT: v_and_b32_e32 v0, 1, v0
+; CHECK-NEXT: v_cmp_eq_u32_e32 vcc, 1, v0
+; CHECK-NEXT: s_waitcnt vmcnt(0) lgkmcnt(0)
+; CHECK-NEXT: v_cndmask_b32_e32 v0, v6, v5, vcc
+; CHECK-NEXT: s_setpc_b64 s[30:31]
+ %ld0 = load i32, ptr addrspace(1) %a
+ %ld1 = load i32, ptr %b
+ %select = select i1 %cond, i32 %ld0, i32 %ld1
+ ret i32 %select
+}
+
+define i8 @select_load_i8_p1(i1 %cond, ptr addrspace(1) %a, ptr addrspace(1) %b) {
+; CHECK-LABEL: select_load_i8_p1:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
+; CHECK-NEXT: global_load_ubyte v5, v[1:2], off
+; CHECK-NEXT: global_load_ubyte v6, v[3:4], off
+; CHECK-NEXT: v_and_b32_e32 v0, 1, v0
+; CHECK-NEXT: v_cmp_eq_u32_e32 vcc, 1, v0
+; CHECK-NEXT: s_waitcnt vmcnt(0)
+; CHECK-NEXT: v_cndmask_b32_e32 v0, v6, v5, vcc
+; CHECK-NEXT: s_setpc_b64 s[30:31]
+ %ld0 = load i8, ptr addrspace(1) %a
+ %ld1 = load i8, ptr addrspace(1) %b
+ %select = select i1 %cond, i8 %ld0, i8 %ld1
+ ret i8 %select
+}
+
+define i32 @select_load_i32_p1_offset(i1 %cond, ptr addrspace(1) %a, ptr addrspace(1) %b) {
+; CHECK-LABEL: select_load_i32_p1_offset:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
+; CHECK-NEXT: global_load_dword v3, v[1:2], off offset:256
+; CHECK-NEXT: global_load_dword v4, v[1:2], off offset:512
+; CHECK-NEXT: v_and_b32_e32 v0, 1, v0
+; CHECK-NEXT: v_cmp_eq_u32_e32 vcc, 1, v0
+; CHECK-NEXT: s_waitcnt vmcnt(0)
+; CHECK-NEXT: v_cndmask_b32_e32 v0, v4, v3, vcc
+; CHECK-NEXT: s_setpc_b64 s[30:31]
+ %gep.a = getelementptr i8, ptr addrspace(1) %a, i64 256
+ %gep.b = getelementptr i8, ptr addrspace(1) %a, i64 512
+ %ld0 = load i32, ptr addrspace(1) %gep.a
+ %ld1 = load i32, ptr addrspace(1) %gep.b
+ %select = select i1 %cond, i32 %ld0, i32 %ld1
+ ret i32 %select
+}
|
shiltian
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

No description provided.