-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Add test case for xsgetn in basic_filebuf #167937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sterling-Augustine
wants to merge
1
commit into
llvm:main
Choose a base branch
from
Sterling-Augustine:fread_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+73
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the promised follow-up to llvm#167779. It simply adds a test case.
Member
|
@llvm/pr-subscribers-libcxx Author: None (Sterling-Augustine) ChangesThis is the promised follow-up to #167779. It simply adds a test case provided by philnik777 Full diff: https://github.com/llvm/llvm-project/pull/167937.diff 2 Files Affected:
diff --git a/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/xsgetn.pass.cpp b/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/xsgetn.pass.cpp
new file mode 100644
index 0000000000000..ec555ea4d259b
--- /dev/null
+++ b/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/xsgetn.pass.cpp
@@ -0,0 +1,72 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// FILE_DEPENDENCIES: xsgetn.test.dat
+
+// <fstream>
+
+// template <class charT, class traits = char_traits<charT> >
+// class basic_ifstream
+
+// streamsize xsgetn(char_type*, streamsize) override;
+
+// This isn't a required override by the standard, but most implementations override it, since it allows for
+// significantly improved performance in some cases. All of this code is required to work, so this isn't a libc++
+// extension
+
+#include <cassert>
+#include <fstream>
+
+#include "test_macros.h"
+
+int main(int, char**) {
+ {
+ char buffer[10];
+ std::ifstream fs("xsgetn.test.dat");
+ std::filebuf* fb = fs.rdbuf();
+ fb->pubsetbuf(buffer, 10);
+
+ // Ensure that the buffer is set up
+ assert(fb->sgetc() == 't');
+
+ std::string str(5, '\0');
+
+ { // Check that a read smaller than the buffer works fine
+ assert(fb->sgetn(str.data(), 5) == 5);
+ assert(str == "this ");
+ }
+ { // Check that reading up to the buffer end works fine
+ assert(fb->sgetn(str.data(), 5) == 5);
+ assert(str == "is so");
+ }
+ { // Check that reading from an empty buffer, but more than the buffer can hold works fine
+ str.resize(12);
+ assert(fb->sgetn(str.data(), 12) == 12);
+ assert(str == "me random da");
+ }
+ { // Check that reading from a non-empty buffer, and more than the buffer can hold works fine
+ // Fill the buffer up
+ str.resize(2);
+ assert(fb->sgetn(str.data(), 2) == 2);
+ assert(str == "ta");
+
+ // Do the actual check
+ str.resize(12);
+ assert(fb->sgetn(str.data(), 12) == 12);
+ assert(str == " to be able ");
+ }
+ { // Check that trying to read more than the file size works fine
+ str.resize(30);
+ assert(fb->sgetn(str.data(), 30) == 24);
+ str.resize(24);
+ assert(str == "to test buffer behaviour");
+ }
+ }
+
+ return 0;
+}
diff --git a/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/xsgetn.test.dat b/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/xsgetn.test.dat
new file mode 100644
index 0000000000000..06d663b9bf23d
--- /dev/null
+++ b/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/xsgetn.test.dat
@@ -0,0 +1 @@
+this is some random data to be able to test buffer behaviour
\ No newline at end of file
|
philnik777
reviewed
Nov 14, 2025
| #include "test_macros.h" | ||
|
|
||
| int main(int, char**) { | ||
| { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there an additional scope?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the promised follow-up to #167779. It simply adds a test case provided by philnik777