From bfdf7aa1cce60b5b92a760f2b0ee6615485a31d2 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Mon, 17 Nov 2025 17:50:01 -0800 Subject: [PATCH 1/2] [AsmParser] Use a range-based for loop (NFC) Identified with modernize-loop-convert. --- llvm/lib/AsmParser/LLParser.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/llvm/lib/AsmParser/LLParser.cpp b/llvm/lib/AsmParser/LLParser.cpp index 8e3ce4990f437..6cac6455f8bfd 100644 --- a/llvm/lib/AsmParser/LLParser.cpp +++ b/llvm/lib/AsmParser/LLParser.cpp @@ -315,11 +315,10 @@ bool LLParser::validateEndOfModule(bool UpgradeDebugInfo) { return error(NT.second.second, "use of undefined type '%" + Twine(NT.first) + "'"); - for (StringMap >::iterator I = - NamedTypes.begin(), E = NamedTypes.end(); I != E; ++I) - if (I->second.second.isValid()) - return error(I->second.second, - "use of undefined type named '" + I->getKey() + "'"); + for (const auto &NamedType : NamedTypes) + if (NamedType.second.second.isValid()) + return error(NamedType.second.second, + "use of undefined type named '" + NamedType.getKey() + "'"); if (!ForwardRefComdats.empty()) return error(ForwardRefComdats.begin()->second, From 1b4dfc8093ad28ded4b2387857fbc5ac62074f46 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Tue, 18 Nov 2025 07:37:42 -0800 Subject: [PATCH 2/2] Address a comment. --- llvm/lib/AsmParser/LLParser.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/llvm/lib/AsmParser/LLParser.cpp b/llvm/lib/AsmParser/LLParser.cpp index 6cac6455f8bfd..8115094abb2bc 100644 --- a/llvm/lib/AsmParser/LLParser.cpp +++ b/llvm/lib/AsmParser/LLParser.cpp @@ -315,10 +315,10 @@ bool LLParser::validateEndOfModule(bool UpgradeDebugInfo) { return error(NT.second.second, "use of undefined type '%" + Twine(NT.first) + "'"); - for (const auto &NamedType : NamedTypes) - if (NamedType.second.second.isValid()) - return error(NamedType.second.second, - "use of undefined type named '" + NamedType.getKey() + "'"); + for (const auto &[Name, TypeInfo] : NamedTypes) + if (TypeInfo.second.isValid()) + return error(TypeInfo.second, + "use of undefined type named '" + Name + "'"); if (!ForwardRefComdats.empty()) return error(ForwardRefComdats.begin()->second,