From 4cd9579baa9f66e54673567105fd2aa2b1a99fe6 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 20 Nov 2025 17:54:51 +0000 Subject: [PATCH] [Github] Error on HTTP 4xx Errors When downloading bazelisk/buildifier, we use curl, which still returns exit code zero on HTTP 4xx errors unless we pass --fail. This patch adds --fail flags so that error messages are more clear. --- .github/workflows/bazel-checks.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/bazel-checks.yml b/.github/workflows/bazel-checks.yml index 27092d9326aeb..dc9dcb97ce0a8 100644 --- a/.github/workflows/bazel-checks.yml +++ b/.github/workflows/bazel-checks.yml @@ -25,7 +25,7 @@ jobs: uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Setup Buildifier run: | - sudo curl -L https://github.com/bazelbuild/buildtools/releases/download/v8.2.1/buildifier-linux-amd64 -o /usr/bin/buildifier + sudo curl -L https://github.com/bazelbuild/buildtools/releases/download/v8.2.1/buildifier-linux-amd64 -o /usr/bin/buildifier --fail sudo chmod +x /usr/bin/buildifier - name: Run Buildifier run: | @@ -49,7 +49,7 @@ jobs: run: | sudo apt-get update sudo apt-get install -y libmpfr-dev libpfm4-dev m4 libedit-dev - sudo curl -L https://github.com/bazelbuild/bazelisk/releases/download/v1.27.0/bazelisk-amd64.deb > /tmp/bazelisk.deb + sudo curl -L https://github.com/bazelbuild/bazelisk/releases/download/v1.27.0/bazelisk-amd64.deb --fail > /tmp/bazelisk.deb sudo apt-get install -y /tmp/bazelisk.deb rm /tmp/bazelisk.deb - name: Build/Test