Really fix tysan test failing on unsupported arches #169096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'target' is not one of the features recognized by clang tests, and the test doesn't require X86 backend to be built. Specify the target explicitly instead. Remove duplicate `-fsanitize=type` as well.
Member
|
@llvm/pr-subscribers-clang Author: Sergei Barannikov (s-barannikov) Changes'target' is not one of the features recognized by clang tests, and the test doesn't require X86 backend to be built. Specify the target explicitly instead. Remove duplicate Full diff: https://github.com/llvm/llvm-project/pull/169096.diff 1 Files Affected:
diff --git a/clang/test/CodeGen/sanitize-type-outlined.cpp b/clang/test/CodeGen/sanitize-type-outlined.cpp
index 67e2f49e53d34..2c2caa98b21db 100644
--- a/clang/test/CodeGen/sanitize-type-outlined.cpp
+++ b/clang/test/CodeGen/sanitize-type-outlined.cpp
@@ -1,9 +1,7 @@
-// REQUIRES: target=x86_64-linux-gnu
-
-// RUN: %clang -S -fsanitize=type -emit-llvm -o - -fsanitize=type %s \
+// RUN: %clang --target=x86_64-linux-gnu -S -fsanitize=type -emit-llvm -o - %s \
// RUN: -fno-sanitize-type-outline-instrumentation \
// RUN: | FileCheck %s --check-prefixes=CHECK-NO-OUTLINE
-// RUN: %clang -S -fsanitize=type -emit-llvm -o - -fsanitize=type %s \
+// RUN: %clang --target=x86_64-linux-gnu -S -fsanitize=type -emit-llvm -o - %s \
// RUN: -fsanitize-type-outline-instrumentation \
// RUN: | FileCheck %s --check-prefixes=CHECK-OUTLINE
|
🐧 Linux x64 Test Results
|
gbMattN
approved these changes
Nov 21, 2025
Contributor
gbMattN
left a comment
gbMattN
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this- this will be my lesson about merging my changes Friday evening 😅
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/27701 Here is the relevant piece of the build log for the reference |
aadeshps-mcw
pushed a commit
to aadeshps-mcw/llvm-project
that referenced
this pull request
Nov 26, 2025
'target' is not one of the features recognized by clang tests, and the test doesn't require X86 backend to be built. Specify the target explicitly instead. Remove duplicate `-fsanitize=type` as well.
Priyanshu3820
pushed a commit
to Priyanshu3820/llvm-project
that referenced
this pull request
Nov 26, 2025
'target' is not one of the features recognized by clang tests, and the test doesn't require X86 backend to be built. Specify the target explicitly instead. Remove duplicate `-fsanitize=type` as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'target' is not one of the features recognized by clang tests, and the test doesn't require X86 backend to be built. Specify the target explicitly instead. Remove duplicate
-fsanitize=typeas well.