[CIR] Expr cleanup #169138
Draft
[CIR] Expr cleanup #169138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikHuebner
commented
Nov 22, 2025
| !std::is_base_of<mlir::Block, T>::value> struct DominatingPointer; | ||
| template <class T> struct DominatingPointer<T, false> : InvariantValue<T *> {}; | ||
|
|
||
| // template <class T> struct DominatingPointer<T,true> at end of file |
Contributor
Author
There was a problem hiding this comment.
This comment from OGCG is just lying
HendrikHuebner
commented
Nov 26, 2025
| void destroy() { | ||
| if (auxAllocas) | ||
| delete auxAllocas; | ||
| delete extInfo; |
Contributor
Author
There was a problem hiding this comment.
TODO: smart poiners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upstreams much of the cleanup handling logic for conditional cleanups, operator delete cleanup, cleanup flags...
Still work in progress - I just created this to review my own code and figure out how to break it down into smaller PRs (suggestions welcome)