[Clang][LLVM][AArch64]Add support for svrint{32|64}{z|x} intrinsics #169661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
backend:AArch64
clang:frontend
Member
|
@llvm/pr-subscribers-llvm-ir Author: None (CarolineConcatto) ChangesThis patch add supports in Clang for these assembly intrinsics: FRINT32X By adding support for these intrinsics: // Variant is available for _f64 // Variant is available for _f64 // Variant is available for _f64 // Variant is available for _f64 |
Member
|
@llvm/pr-subscribers-backend-aarch64 Author: None (CarolineConcatto) ChangesThis patch add supports in Clang for these assembly intrinsics: FRINT32X By adding support for these intrinsics: // Variant is available for _f64 // Variant is available for _f64 // Variant is available for _f64 // Variant is available for _f64 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for four new SVE2.2 floating-point rounding intrinsics (FRINT32X, FRINT32Z, FRINT64X, FRINT64Z) to both Clang and LLVM. These intrinsics round floating-point values to integer ranges while maintaining floating-point representation.
- Adds LLVM intrinsic definitions and corresponding backend instruction selection
- Adds Clang ACLE builtin definitions for all variants (_m, _x, _z)
- Includes comprehensive test coverage for both LLVM codegen and Clang frontend
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| llvm/test/CodeGen/AArch64/sve2p2-intrinsics-fp-arith.ll | Adds LLVM codegen tests for all four intrinsic variants across float32 and float64 types |
| llvm/lib/Target/AArch64/SVEInstrFormats.td | Updates instruction format definitions to include pattern matching for the new intrinsics |
| llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td | Defines instruction encodings and links them to the SDNode operations |
| llvm/lib/Target/AArch64/AArch64ISelLowering.cpp | Adds intrinsic lowering logic to map LLVM intrinsics to backend operations |
| llvm/include/llvm/IR/IntrinsicsAArch64.td | Declares the four new LLVM intrinsics |
| clang/test/CodeGen/AArch64/sve2p2-intrinsics/acle_sve_rintx.c | Adds Clang frontend tests verifying intrinsic code generation |
| clang/include/clang/Basic/arm_sve.td | Declares the Clang ACLE builtins with proper target guards |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CarolineConcatto
force-pushed
the
frint_acle
branch
from
914f3f2 to
0d398d5
Compare
This patch add supports in Clang for these assembly intrinsics: FRINT32X FRINT32Z FRINT64X FRINT64Z By adding support for these intrinsics: // Variant is available for _f64 svfloat32_t svrint32x[_f32]_z(svbool_t pg, svfloat32_t zn); // Variant is available for _f64 svfloat32_t svrint32x[_f32]_x(svbool_t pg, svfloat32_t zn); // Variant is available for _f64 svfloat32_t svrint32x[_f32]_m(svfloat32_t inactive, svbool_t pg, svfloat32_t zn); // Variant is available for _f64 svfloat32_t svrint32z[_f32]_z(svbool_t pg, svfloat32_t zn); // Variant is available for _f64 svfloat32_t svrint32z[_f32]_x(svbool_t pg, svfloat32_t zn); // Variant is available for _f64 svfloat32_t svrint32z[_f32]_m(svfloat32_t inactive, svbool_t pg, svfloat32_t zn); // Variant is available for _f64 svfloat32_t svrint64x[_f32]_z(svbool_t pg, svfloat32_t zn); // Variant is available for _f64 svfloat32_t svrint64x[_f32]_x(svbool_t pg, svfloat32_t zn); // Variant is available for _f64 svfloat32_t svrint64x[_f32]_m(svfloat32_t inactive, svbool_t pg, svfloat32_t zn); // Variant is available for _f64 svfloat32_t svrint64z[_f32]_z(svbool_t pg, svfloat32_t zn); // Variant is available for _f64 svfloat32_t svrint64z[_f32]_x(svbool_t pg, svfloat32_t zn); // Variant is available for _f64 svfloat32_t svrint64z[_f32]_m(svfloat32_t inactive, svbool_t pg, svfloat32_t zn); ``` according to the ACLE[1] [1]ARM-software/acle#412
CarolineConcatto
force-pushed
the
frint_acle
branch
from
0d398d5 to
da39b98
Compare
kmclaughlin-arm
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add supports in Clang for these assembly intrinsics:
FRINT32X
FRINT32Z
FRINT64X
FRINT64Z
By adding support for these intrinsics:
// Variant is available for _f64
svfloat32_t svrint32x[_f32]_z(svbool_t pg, svfloat32_t zn); // Variant is available for _f64
svfloat32_t svrint32x[_f32]_x(svbool_t pg, svfloat32_t zn); // Variant is available for _f64
svfloat32_t svrint32x[_f32]_m(svfloat32_t inactive, svbool_t pg, svfloat32_t zn);
// Variant is available for _f64
svfloat32_t svrint32z[_f32]_z(svbool_t pg, svfloat32_t zn); // Variant is available for _f64
svfloat32_t svrint32z[_f32]_x(svbool_t pg, svfloat32_t zn); // Variant is available for _f64
svfloat32_t svrint32z[_f32]_m(svfloat32_t inactive, svbool_t pg, svfloat32_t zn);
// Variant is available for _f64
svfloat32_t svrint64x[_f32]_z(svbool_t pg, svfloat32_t zn); // Variant is available for _f64
svfloat32_t svrint64x[_f32]_x(svbool_t pg, svfloat32_t zn); // Variant is available for _f64
svfloat32_t svrint64x[_f32]_m(svfloat32_t inactive, svbool_t pg, svfloat32_t zn);
// Variant is available for _f64
svfloat32_t svrint64z[_f32]_z(svbool_t pg, svfloat32_t zn); // Variant is available for _f64
svfloat32_t svrint64z[_f32]_x(svbool_t pg, svfloat32_t zn); // Variant is available for _f64
svfloat32_t svrint64z[_f32]_m(svfloat32_t inactive, svbool_t pg, svfloat32_t zn);