Skip to content

Conversation

@charles-zablit
Copy link
Contributor

skipped_categories_list was unused in dotest.py. This patch ensures it's used where intended.

2238dcc switched to using configuration.skip_categories directly when reformatting the code, making skipped_categories_list unused.

@llvmbot
Copy link
Member

llvmbot commented Nov 28, 2025

@llvm/pr-subscribers-lldb

Author: Charles Zablit (charles-zablit)

Changes

skipped_categories_list was unused in dotest.py. This patch ensures it's used where intended.

2238dcc switched to using configuration.skip_categories directly when reformatting the code, making skipped_categories_list unused.


Full diff: https://github.com/llvm/llvm-project/pull/169903.diff

1 Files Affected:

  • (modified) lldb/packages/Python/lldbsuite/test/dotest.py (+1-5)
diff --git a/lldb/packages/Python/lldbsuite/test/dotest.py b/lldb/packages/Python/lldbsuite/test/dotest.py
index 63f7df4de1894..f280bd2b3887b 100644
--- a/lldb/packages/Python/lldbsuite/test/dotest.py
+++ b/lldb/packages/Python/lldbsuite/test/dotest.py
@@ -1108,11 +1108,7 @@ def run_suite():
     checkDAPSupport()
 
     skipped_categories_list = ", ".join(configuration.skip_categories)
-    print(
-        "Skipping the following test categories: {}".format(
-            configuration.skip_categories
-        )
-    )
+    print(f"Skipping the following test categories: {skipped_categories_list}")
 
     for testdir in configuration.testdirs:
         for dirpath, dirnames, filenames in os.walk(testdir):

@charles-zablit charles-zablit merged commit c2eb332 into llvm:main Nov 28, 2025
12 checks passed
aahrun pushed a commit to aahrun/llvm-project that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants