[CIR][X86] Implement lowering for AVX512 ktest builtins #169985
+273
−6
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -465,3 +465,127 @@ __mmask64 test_kmov_q(__mmask64 A) { | |||||
|
|
||||||
| return __builtin_ia32_kmovq(A); | ||||||
| } | ||||||
|
|
||||||
| unsigned char test_kortestc_mask32_u8(__mmask32 __A, __mmask32 __B) { | ||||||
| // CIR-LABEL: _kortestc_mask32_u8 | ||||||
| // CIR: [[ALL_ONES:%.*]] = cir.const #cir.int<4294967295> : !u32i | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
I prefer to have the |
||||||
| // CIR: [[LHS:%.*]] = cir.cast bitcast {{.*}} : !u32i -> !cir.vector<32 x !cir.int<u, 1>> | ||||||
| // CIR: [[RHS:%.*]] = cir.cast bitcast {{.*}} : !u32i -> !cir.vector<32 x !cir.int<u, 1>> | ||||||
| // CIR: [[OR:%.*]] = cir.binop(or, [[LHS]], [[RHS]]) : !cir.vector<32 x !cir.int<u, 1>> | ||||||
| // CIR: [[OR_INT:%.*]] = cir.cast bitcast [[OR]] : !cir.vector<32 x !cir.int<u, 1>> -> !u32i | ||||||
| // CIR: [[CMP:%.*]] = cir.cmp(eq, [[OR_INT]], [[ALL_ONES]]) : !u32i, !cir.bool | ||||||
| // CIR: [[B2I:%.*]] = cir.cast bool_to_int [[CMP]] : !cir.bool -> !s32i | ||||||
| // CIR: cir.cast integral [[B2I]] : !s32i -> !u8i | ||||||
|
|
||||||
| // LLVM-LABEL: _kortestc_mask32_u8 | ||||||
| // LLVM: [[LHS:%.*]] = bitcast i32 %{{.*}} to <32 x i1> | ||||||
| // LLVM: [[RHS:%.*]] = bitcast i32 %{{.*}} to <32 x i1> | ||||||
| // LLVM: [[OR:%.*]] = or <32 x i1> [[LHS]], [[RHS]] | ||||||
| // LLVM: [[CAST:%.*]] = bitcast <32 x i1> [[OR]] to i32 | ||||||
| // LLVM: [[CMP:%.*]] = icmp eq i32 [[CAST]], -1 | ||||||
| // LLVM: [[ZEXT:%.*]] = zext i1 [[CMP]] to i32 | ||||||
| // LLVM: trunc i32 [[ZEXT]] to i8 | ||||||
|
|
||||||
| // OGCG-LABEL: _kortestc_mask32_u8 | ||||||
| // OGCG: bitcast i32 %{{.*}} to <32 x i1> | ||||||
| // OGCG: bitcast i32 %{{.*}} to <32 x i1> | ||||||
| // OGCG: or <32 x i1> {{.*}}, {{.*}} | ||||||
| // OGCG: bitcast <32 x i1> {{.*}} to i32 | ||||||
| // OGCG: icmp eq i32 {{.*}}, -1 | ||||||
| // OGCG: zext i1 {{.*}} to i32 | ||||||
| // OGCG: trunc i32 {{.*}} to i8 | ||||||
|
Comment on lines
+490
to
+496
Contributor
There was a problem hiding this comment. Can you capture the values here as you have in the LLVM checks? |
||||||
| return _kortestc_mask32_u8(__A, __B); | ||||||
| } | ||||||
|
|
||||||
| unsigned char test_kortestc_mask64_u8(__mmask64 __A, __mmask64 __B) { | ||||||
| // CIR-LABEL: _kortestc_mask64_u8 | ||||||
| // CIR: [[ALL_ONES:%.*]] = cir.const #cir.int<18446744073709551615> : !u64i | ||||||
| // CIR: [[LHS:%.*]] = cir.cast bitcast {{.*}} : !u64i -> !cir.vector<64 x !cir.int<u, 1>> | ||||||
| // CIR: [[RHS:%.*]] = cir.cast bitcast {{.*}} : !u64i -> !cir.vector<64 x !cir.int<u, 1>> | ||||||
| // CIR: [[OR:%.*]] = cir.binop(or, [[LHS]], [[RHS]]) : !cir.vector<64 x !cir.int<u, 1>> | ||||||
| // CIR: [[OR_INT:%.*]] = cir.cast bitcast [[OR]] : !cir.vector<64 x !cir.int<u, 1>> -> !u64i | ||||||
| // CIR: [[CMP:%.*]] = cir.cmp(eq, [[OR_INT]], [[ALL_ONES]]) : !u64i, !cir.bool | ||||||
| // CIR: [[B2I:%.*]] = cir.cast bool_to_int [[CMP]] : !cir.bool -> !s32i | ||||||
| // CIR: cir.cast integral [[B2I]] : !s32i -> !u8i | ||||||
|
|
||||||
| // LLVM-LABEL: _kortestc_mask64_u8 | ||||||
| // LLVM: [[LHS:%.*]] = bitcast i64 %{{.*}} to <64 x i1> | ||||||
| // LLVM: [[RHS:%.*]] = bitcast i64 %{{.*}} to <64 x i1> | ||||||
| // LLVM: [[OR:%.*]] = or <64 x i1> [[LHS]], [[RHS]] | ||||||
| // LLVM: [[CAST:%.*]] = bitcast <64 x i1> [[OR]] to i64 | ||||||
| // LLVM: [[CMP:%.*]] = icmp eq i64 [[CAST]], -1 | ||||||
| // LLVM: [[ZEXT:%.*]] = zext i1 [[CMP]] to i32 | ||||||
| // LLVM: trunc i32 [[ZEXT]] to i8 | ||||||
|
|
||||||
| // OGCG-LABEL: _kortestc_mask64_u8 | ||||||
| // OGCG: bitcast i64 %{{.*}} to <64 x i1> | ||||||
| // OGCG: bitcast i64 %{{.*}} to <64 x i1> | ||||||
| // OGCG: or <64 x i1> {{.*}}, {{.*}} | ||||||
| // OGCG: bitcast <64 x i1> {{.*}} to i64 | ||||||
| // OGCG: icmp eq i64 {{.*}}, -1 | ||||||
| // OGCG: zext i1 {{.*}} to i32 | ||||||
| // OGCG: trunc i32 {{.*}} to i8 | ||||||
| return _kortestc_mask64_u8(__A, __B); | ||||||
| } | ||||||
|
|
||||||
| unsigned char test_kortestz_mask32_u8(__mmask32 __A, __mmask32 __B) { | ||||||
| // CIR-LABEL: _kortestz_mask32_u8 | ||||||
| // CIR: [[ZERO:%.*]] = cir.const #cir.int<0> : !u32i | ||||||
| // CIR: [[LHS:%.*]] = cir.cast bitcast {{.*}} : !u32i -> !cir.vector<32 x !cir.int<u, 1>> | ||||||
| // CIR: [[RHS:%.*]] = cir.cast bitcast {{.*}} : !u32i -> !cir.vector<32 x !cir.int<u, 1>> | ||||||
| // CIR: [[OR:%.*]] = cir.binop(or, [[LHS]], [[RHS]]) : !cir.vector<32 x !cir.int<u, 1>> | ||||||
| // CIR: [[OR_INT:%.*]] = cir.cast bitcast [[OR]] : !cir.vector<32 x !cir.int<u, 1>> -> !u32i | ||||||
| // CIR: [[CMP:%.*]] = cir.cmp(eq, [[OR_INT]], [[ZERO]]) : !u32i, !cir.bool | ||||||
| // CIR: [[B2I:%.*]] = cir.cast bool_to_int [[CMP]] : !cir.bool -> !s32i | ||||||
| // CIR: cir.cast integral [[B2I]] : !s32i -> !u8i | ||||||
|
|
||||||
| // LLVM-LABEL: _kortestz_mask32_u8 | ||||||
| // LLVM: [[LHS:%.*]] = bitcast i32 %{{.*}} to <32 x i1> | ||||||
| // LLVM: [[RHS:%.*]] = bitcast i32 %{{.*}} to <32 x i1> | ||||||
| // LLVM: [[OR:%.*]] = or <32 x i1> [[LHS]], [[RHS]] | ||||||
| // LLVM: [[CAST:%.*]] = bitcast <32 x i1> [[OR]] to i32 | ||||||
| // LLVM: [[CMP:%.*]] = icmp eq i32 [[CAST]], 0 | ||||||
| // LLVM: [[ZEXT:%.*]] = zext i1 [[CMP]] to i32 | ||||||
| // LLVM: trunc i32 [[ZEXT]] to i8 | ||||||
|
|
||||||
| // OGCG-LABEL: _kortestz_mask32_u8 | ||||||
| // OGCG: bitcast i32 %{{.*}} to <32 x i1> | ||||||
| // OGCG: bitcast i32 %{{.*}} to <32 x i1> | ||||||
| // OGCG: or <32 x i1> {{.*}}, {{.*}} | ||||||
| // OGCG: bitcast <32 x i1> {{.*}} to i32 | ||||||
| // OGCG: icmp eq i32 {{.*}}, 0 | ||||||
| // OGCG: zext i1 {{.*}} to i32 | ||||||
| // OGCG: trunc i32 {{.*}} to i8 | ||||||
| return _kortestz_mask32_u8(__A, __B); | ||||||
| } | ||||||
|
|
||||||
| unsigned char test_kortestz_mask64_u8(__mmask64 __A, __mmask64 __B) { | ||||||
| // CIR-LABEL: _kortestz_mask64_u8 | ||||||
| // CIR: [[ZERO:%.*]] = cir.const #cir.int<0> : !u64i | ||||||
| // CIR: [[LHS:%.*]] = cir.cast bitcast {{.*}} : !u64i -> !cir.vector<64 x !cir.int<u, 1>> | ||||||
| // CIR: [[RHS:%.*]] = cir.cast bitcast {{.*}} : !u64i -> !cir.vector<64 x !cir.int<u, 1>> | ||||||
| // CIR: [[OR:%.*]] = cir.binop(or, [[LHS]], [[RHS]]) : !cir.vector<64 x !cir.int<u, 1>> | ||||||
| // CIR: [[OR_INT:%.*]] = cir.cast bitcast [[OR]] : !cir.vector<64 x !cir.int<u, 1>> -> !u64i | ||||||
| // CIR: [[CMP:%.*]] = cir.cmp(eq, [[OR_INT]], [[ZERO]]) : !u64i, !cir.bool | ||||||
| // CIR: [[B2I:%.*]] = cir.cast bool_to_int [[CMP]] : !cir.bool -> !s32i | ||||||
| // CIR: cir.cast integral [[B2I]] : !s32i -> !u8i | ||||||
|
|
||||||
| // LLVM-LABEL: _kortestz_mask64_u8 | ||||||
| // LLVM: [[LHS:%.*]] = bitcast i64 %{{.*}} to <64 x i1> | ||||||
| // LLVM: [[RHS:%.*]] = bitcast i64 %{{.*}} to <64 x i1> | ||||||
| // LLVM: [[OR:%.*]] = or <64 x i1> [[LHS]], [[RHS]] | ||||||
| // LLVM: [[CAST:%.*]] = bitcast <64 x i1> [[OR]] to i64 | ||||||
| // LLVM: [[CMP:%.*]] = icmp eq i64 [[CAST]], 0 | ||||||
| // LLVM: [[ZEXT:%.*]] = zext i1 [[CMP]] to i32 | ||||||
| // LLVM: trunc i32 [[ZEXT]] to i8 | ||||||
|
|
||||||
| // OGCG-LABEL: _kortestz_mask64_u8 | ||||||
| // OGCG: bitcast i64 %{{.*}} to <64 x i1> | ||||||
| // OGCG: bitcast i64 %{{.*}} to <64 x i1> | ||||||
| // OGCG: or <64 x i1> {{.*}}, {{.*}} | ||||||
| // OGCG: bitcast <64 x i1> {{.*}} to i64 | ||||||
| // OGCG: icmp eq i64 {{.*}}, 0 | ||||||
| // OGCG: zext i1 {{.*}} to i32 | ||||||
| // OGCG: trunc i32 {{.*}} to i8 | ||||||
| return _kortestz_mask64_u8(__A, __B); | ||||||
| } | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -208,3 +208,68 @@ __mmask8 test_kmov_b(__mmask8 A) { | |
| // OGCG: bitcast <8 x i1> {{.*}} to i8 | ||
| return __builtin_ia32_kmovb(A); | ||
| } | ||
|
|
||
|
|
||
| unsigned char test_kortestc_mask8_u8(__mmask8 __A, __mmask8 __B) { | ||
| // CIR-LABEL: _kortestc_mask8_u8 | ||
| // CIR: [[ALL_ONES:%.*]] = cir.const #cir.int<255> : !u8i | ||
| // CIR: [[LHS:%.*]] = cir.cast bitcast {{.*}} : !u8i -> !cir.vector<8 x !cir.int<u, 1>> | ||
| // CIR: [[RHS:%.*]] = cir.cast bitcast {{.*}} : !u8i -> !cir.vector<8 x !cir.int<u, 1>> | ||
| // CIR: [[OR:%.*]] = cir.binop(or, [[LHS]], [[RHS]]) : !cir.vector<8 x !cir.int<u, 1>> | ||
| // CIR: [[OR_INT:%.*]] = cir.cast bitcast [[OR]] : !cir.vector<8 x !cir.int<u, 1>> -> !u8i | ||
| // CIR: [[CMP:%.*]] = cir.cmp(eq, [[OR_INT]], [[ALL_ONES]]) : !u8i, !cir.bool | ||
| // CIR: cir.cast bool_to_int [[CMP]] : !cir.bool -> !s32i | ||
| // CIR: cir.cast integral {{.*}} : !s32i -> !u8i | ||
|
|
||
|
|
||
| // LLVM-LABEL: _kortestc_mask8_u8 | ||
| // LLVM: [[LHS:%.*]] = bitcast i8 %{{.*}} to <8 x i1> | ||
| // LLVM: [[RHS:%.*]] = bitcast i8 %{{.*}} to <8 x i1> | ||
| // LLVM: [[OR:%.*]] = or <8 x i1> [[LHS]], [[RHS]] | ||
| // LLVM: [[CAST:%.*]] = bitcast <8 x i1> [[OR]] to i8 | ||
| // LLVM: [[CMP:%.*]] = icmp eq i8 [[CAST]], -1 | ||
| // LLVM: [[ZEXT:%.*]] = zext i1 [[CMP]] to i32 | ||
| // LLVM: trunc i32 [[ZEXT]] to i8 | ||
|
|
||
| // OGCG-LABEL: _kortestc_mask8_u8 | ||
| // OGCG: bitcast i8 %{{.*}} to <8 x i1> | ||
| // OGCG: bitcast i8 %{{.*}} to <8 x i1> | ||
| // OGCG: or <8 x i1> {{.*}}, {{.*}} | ||
| // OGCG: bitcast <8 x i1> {{.*}} to i8 | ||
| // OGCG: icmp eq i8 {{.*}}, -1 | ||
| // OGCG: zext i1 {{.*}} to i32 | ||
| // OGCG: trunc i32 {{.*}} to i8 | ||
| return _kortestc_mask8_u8(__A,__B); | ||
| } | ||
|
|
||
| unsigned char test_kortestz_mask8_u8(__mmask8 __A, __mmask8 __B) { | ||
| // CIR-LABEL: _kortestz_mask8_u8 | ||
| // CIR: [[ZERO:%.*]] = cir.const #cir.int<0> : !u8i | ||
| // CIR: [[LHS:%.*]] = cir.cast bitcast {{.*}} : !u8i -> !cir.vector<8 x !cir.int<u, 1>> | ||
| // CIR: [[RHS:%.*]] = cir.cast bitcast {{.*}} : !u8i -> !cir.vector<8 x !cir.int<u, 1>> | ||
| // CIR: [[OR:%.*]] = cir.binop(or, [[LHS]], [[RHS]]) : !cir.vector<8 x !cir.int<u, 1>> | ||
| // CIR: [[OR_INT:%.*]] = cir.cast bitcast [[OR]] : !cir.vector<8 x !cir.int<u, 1>> -> !u8i | ||
| // CIR: [[CMP:%.*]] = cir.cmp(eq, [[OR_INT]], [[ZERO]]) : !u8i, !cir.bool | ||
| // CIR: cir.cast bool_to_int [[CMP]] : !cir.bool -> !s32i | ||
| // CIR: cir.cast integral {{.*}} : !s32i -> !u8i | ||
|
|
||
|
|
||
| // LLVM-LABEL: _kortestz_mask8_u8 | ||
| // LLVM: [[LHS:%.*]] = bitcast i8 %{{.*}} to <8 x i1> | ||
| // LLVM: [[RHS:%.*]] = bitcast i8 %{{.*}} to <8 x i1> | ||
| // LLVM: [[OR:%.*]] = or <8 x i1> [[LHS]], [[RHS]] | ||
| // LLVM: [[CAST:%.*]] = bitcast <8 x i1> [[OR]] to i8 | ||
| // LLVM: [[CMP:%.*]] = icmp eq i8 [[CAST]], 0 | ||
| // LLVM: [[ZEXT:%.*]] = zext i1 [[CMP]] to i32 | ||
| // LLVM: trunc i32 [[ZEXT]] to i8 | ||
|
|
||
| // OGCG-LABEL: _kortestz_mask8_u8 | ||
| // OGCG: bitcast i8 %{{.*}} to <8 x i1> | ||
| // OGCG: bitcast i8 %{{.*}} to <8 x i1> | ||
| // OGCG: or <8 x i1> {{.*}}, {{.*}} | ||
| // OGCG: bitcast <8 x i1> {{.*}} to i8 | ||
| // OGCG: icmp eq i8 {{.*}}, 0 | ||
| // OGCG: zext i1 {{.*}} to i32 | ||
| // OGCG: trunc i32 {{.*}} to i8 | ||
| return _kortestz_mask8_u8(__A,__B); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -228,3 +228,59 @@ __mmask16 test_kmov_w(__mmask16 A) { | |
| // OGCG: bitcast <16 x i1> {{.*}} to i16 | ||
| return __builtin_ia32_kmovw(A); | ||
| } | ||
|
|
||
| int test_mm512_kortestc(__mmask16 __A, __mmask16 __B) { | ||
| // CIR-LABEL: _mm512_kortestc | ||
| // CIR: [[ALL_ONES:%.*]] = cir.const #cir.int<65535> : !u16i | ||
| // CIR: [[LHS:%.*]] = cir.cast bitcast {{.*}} : !u16i -> !cir.vector<16 x !cir.int<u, 1>> | ||
| // CIR: [[RHS:%.*]] = cir.cast bitcast {{.*}} : !u16i -> !cir.vector<16 x !cir.int<u, 1>> | ||
| // CIR: [[OR:%.*]] = cir.binop(or, [[LHS]], [[RHS]]) : !cir.vector<16 x !cir.int<u, 1>> | ||
| // CIR: [[OR_INT:%.*]] = cir.cast bitcast [[OR]] : !cir.vector<16 x !cir.int<u, 1>> -> !u16i | ||
| // CIR: [[CMP:%.*]] = cir.cmp(eq, [[OR_INT]], [[ALL_ONES]]) : !u16i, !cir.bool | ||
| // CIR: cir.cast bool_to_int [[CMP]] : !cir.bool -> !s32i | ||
|
|
||
| // LLVM-LABEL: _mm512_kortestc | ||
| // LLVM: [[LHS:%.*]] = bitcast i16 %{{.*}} to <16 x i1> | ||
| // LLVM: [[RHS:%.*]] = bitcast i16 %{{.*}} to <16 x i1> | ||
| // LLVM: [[OR:%.*]] = or <16 x i1> [[LHS]], [[RHS]] | ||
| // LLVM: [[CAST:%.*]] = bitcast <16 x i1> [[OR]] to i16 | ||
| // LLVM: [[CMP:%.*]] = icmp eq i16 [[CAST]], -1 | ||
| // LLVM: zext i1 [[CMP]] to i32 | ||
|
|
||
| // OGCG-LABEL: _mm512_kortestc | ||
| // OGCG: bitcast i16 %{{.*}} to <16 x i1> | ||
| // OGCG: bitcast i16 %{{.*}} to <16 x i1> | ||
| // OGCG: or <16 x i1> {{.*}}, {{.*}} | ||
| // OGCG: bitcast <16 x i1> {{.*}} to i16 | ||
| // OGCG: icmp eq i16 {{.*}}, -1 | ||
| // OGCG: zext i1 {{.*}} to i32 | ||
| return _mm512_kortestc(__A,__B); | ||
| } | ||
|
|
||
| int test_mm512_kortestz(__mmask16 __A, __mmask16 __B) { | ||
| // CIR-LABEL: _mm512_kortestz | ||
| // CIR: [[ZERO:%.*]] = cir.const #cir.int<0> : !u16i | ||
| // CIR: [[LHS:%.*]] = cir.cast bitcast {{.*}} : !u16i -> !cir.vector<16 x !cir.int<u, 1>> | ||
| // CIR: [[RHS:%.*]] = cir.cast bitcast {{.*}} : !u16i -> !cir.vector<16 x !cir.int<u, 1>> | ||
| // CIR: [[OR:%.*]] = cir.binop(or, [[LHS]], [[RHS]]) : !cir.vector<16 x !cir.int<u, 1>> | ||
| // CIR: [[OR_INT:%.*]] = cir.cast bitcast [[OR]] : !cir.vector<16 x !cir.int<u, 1>> -> !u16i | ||
| // CIR: [[CMP:%.*]] = cir.cmp(eq, [[OR_INT]], [[ZERO]]) : !u16i, !cir.bool | ||
| // CIR: cir.cast bool_to_int [[CMP]] : !cir.bool -> !s32i | ||
|
|
||
| // LLVM-LABEL: _mm512_kortestz | ||
| // LLVM: [[LHS:%.*]] = bitcast i16 %{{.*}} to <16 x i1> | ||
| // LLVM: [[RHS:%.*]] = bitcast i16 %{{.*}} to <16 x i1> | ||
| // LLVM: [[OR:%.*]] = or <16 x i1> [[LHS]], [[RHS]] | ||
| // LLVM: [[CAST:%.*]] = bitcast <16 x i1> [[OR]] to i16 | ||
| // LLVM: [[CMP:%.*]] = icmp eq i16 [[CAST]], 0 | ||
| // LLVM: zext i1 [[CMP]] to i32 | ||
|
|
||
| // OGCG-LABEL: _mm512_kortestz | ||
| // OGCG: bitcast i16 %{{.*}} to <16 x i1> | ||
| // OGCG: bitcast i16 %{{.*}} to <16 x i1> | ||
| // OGCG: or <16 x i1> {{.*}}, {{.*}} | ||
| // OGCG: bitcast <16 x i1> {{.*}} to i16 | ||
| // OGCG: icmp eq i16 {{.*}}, 0 | ||
| // OGCG: zext i1 {{.*}} to i32 | ||
| return _mm512_kortestz(__A,__B); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.