Skip to content

[clang-repl] Drop CodeGen module when an input has parse errors #169989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Open

[clang-repl] Drop CodeGen module when an input has parse errors #169989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions clang/lib/Interpreter/IncrementalAction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,17 @@ std::unique_ptr<llvm::Module> IncrementalAction::GenModule() {
return nullptr;
}

void IncrementalAction::discardCurrentCodeGenModule() {
if (CodeGenerator *CG = getCodeGen()) {
if (auto *CurM = CG->GetModule()) {
llvm::LLVMContext &Ctx = CurM->getContext();
std::string Name = CurM->getName().str();
std::unique_ptr<llvm::Module> Dead(CG->ReleaseModule());
CG->StartModule(Name, Ctx);
}
Copy link
Member Author

@anutosh491 anutosh491 Nov 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used the variable name Dead for now ! Can you use Discarded or something along those lines I think

}
}

CodeGenerator *IncrementalAction::getCodeGen() const {
FrontendAction *WrappedAct = getWrapped();
if (!WrappedAct || !WrappedAct->hasIRSupport())
Expand Down
2 changes: 2 additions & 0 deletions clang/lib/Interpreter/IncrementalAction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ class IncrementalAction : public WrapperFrontendAction {

/// Generate an LLVM module for the most recent parsed input.
std::unique_ptr<llvm::Module> GenModule();

void discardCurrentCodeGenModule();
Copy link
Member Author

@anutosh491 anutosh491 Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add a comment explaining the purpose behind the function (just like we do for above functions) if needed !

};

class InProcessPrintingASTConsumer final : public MultiplexConsumer {
Expand Down
1 change: 1 addition & 0 deletions clang/lib/Interpreter/IncrementalParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ IncrementalParser::ParseOrWrapTopLevelDecl() {

DiagnosticsEngine &Diags = S.getDiagnostics();
if (Diags.hasErrorOccurred()) {
Act->discardCurrentCodeGenModule();
CleanUpPTU(C.getTranslationUnitDecl());

Diags.Reset(/*soft=*/true);
Expand Down