Skip to content

[MLIR][linalg] Erase effectful producer after fusion if it's no longer used #170036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abulavin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[MLIR][linalg] Erase effectful producer after fusion if it's no longer used #170036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mlir/lib/Dialect/Linalg/Transforms/ElementwiseOpFusion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,12 @@ class FuseElementwiseOps : public OpRewritePattern<GenericOp> {
});
}
rewriter.eraseOp(genericOp);
// If after fusion, the producer no longer has uses, erase it. Usually the
// greedy pattern driver takes care of this, however if the producer
// contains ops with memory effects it won't be considered trivially dead.
if (producer->use_empty())
rewriter.eraseOp(producer);

return success();
}
return failure();
Expand Down
34 changes: 34 additions & 0 deletions mlir/test/Dialect/Linalg/fusion-elementwise-ops.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,3 +1056,37 @@ module {
// CHECK: tensor.expand_shape
// CHECK: linalg.generic {{.*}}, iterator_types = ["parallel", "parallel", "parallel", "parallel", "parallel", "parallel", "reduction"]}
// CHECK-SAME: ins(%[[ARG0]], %[[FUSED]]#1 : tensor<1x1x2x1xf32>, tensor<4x1x1x1xf32>)

// -----

#map = affine_map<(d0) -> (d0)>

module {
func.func @remove_effectful_producer_after_fusion_if_no_uses(%arg0: bf16, %arg1: memref<2xbf16>, %arg2: memref<2xbf16>) {
%c0 = arith.constant 0 : index
%0 = tensor.empty() : tensor<2xbf16>
%1 = linalg.generic {indexing_maps = [#map], iterator_types = ["parallel"]} outs(%0 : tensor<2xbf16>) {
^bb0(%out: bf16):
%2 = memref.atomic_rmw addf %arg0, %arg1[%c0] : (bf16, memref<2xbf16>) -> bf16
linalg.yield %2 : bf16
} -> tensor<2xbf16>

linalg.generic {indexing_maps = [#map], iterator_types = ["parallel"]} ins(%1 : tensor<2xbf16>) {
^bb0(%in: bf16):
memref.store %in, %arg2[%c0] : memref<2xbf16>
linalg.yield
}
return
}
}

// CHECK-LABEL: func.func @remove_effectful_producer_after_fusion_if_no_uses
// CHECK-SAME: %[[ARG0:.*]]: bf16,
// CHECK-SAME: %[[ARG1:.*]]: memref<2xbf16>,
// CHECK-SAME: %[[ARG2:.*]]: memref<2xbf16>)
// CHECK-NOT: memref.atomic_rmw addf %[[ARG0]], %[[ARG1]]
// CHECK: linalg.generic
// CHECK: %[[ATOMIC_RMW:.*]] = memref.atomic_rmw addf %[[ARG0]], %[[ARG1]]
// CHECK: memref.store %[[ATOMIC_RMW]], %[[ARG2]]
// CHECK: linalg.yield %[[ATOMIC_RMW]]
// CHECK: return