diff --git a/llvm/lib/Target/AMDGPU/GCNSubtarget.h b/llvm/lib/Target/AMDGPU/GCNSubtarget.h index e567176e658b3..34eb8b2266311 100644 --- a/llvm/lib/Target/AMDGPU/GCNSubtarget.h +++ b/llvm/lib/Target/AMDGPU/GCNSubtarget.h @@ -1868,6 +1868,12 @@ class GCNSubtarget final : public AMDGPUGenSubtargetInfo, return GFX1250Insts && getGeneration() == GFX12; } + // src_flat_scratch_hi cannot be used as a source in SALU producing a 64-bit + // result. + bool hasFlatScratchHiInB64InstHazard() const { + return GFX1250Insts && getGeneration() == GFX12; + } + /// \returns true if the subtarget supports clusters of workgroups. bool hasClusters() const { return HasClusters; } diff --git a/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp b/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp index da019b6e476df..50860a9a8e4c1 100644 --- a/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp +++ b/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp @@ -6256,6 +6256,17 @@ bool SIInstrInfo::isLegalRegOperand(const MachineInstr &MI, unsigned OpIdx, (int)OpIdx == AMDGPU::getNamedOperandIdx(Opc, AMDGPU::OpName::src0) && RI.isSGPRReg(MRI, MO.getReg())) return false; + + if (ST.hasFlatScratchHiInB64InstHazard() && + MO.getReg() == AMDGPU::SRC_FLAT_SCRATCH_BASE_HI && isSALU(MI)) { + if (const MachineOperand *Dst = getNamedOperand(MI, AMDGPU::OpName::sdst)) { + if (AMDGPU::getRegBitWidth(*MRI.getRegClass(Dst->getReg())) == 64) + return false; + } + if (Opc == AMDGPU::S_BITCMP0_B64 || Opc == AMDGPU::S_BITCMP1_B64) + return false; + } + return true; } diff --git a/llvm/test/CodeGen/AMDGPU/hazard-gfx1250-flat-scr-hi.mir b/llvm/test/CodeGen/AMDGPU/hazard-gfx1250-flat-scr-hi.mir new file mode 100644 index 0000000000000..e661b6859e09d --- /dev/null +++ b/llvm/test/CodeGen/AMDGPU/hazard-gfx1250-flat-scr-hi.mir @@ -0,0 +1,145 @@ +# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 6 +# RUN: llc -mtriple=amdgcn -mcpu=gfx1250 -run-pass si-fold-operands %s -o - | FileCheck -check-prefix=GCN %s + +--- +name: s_ashr_i64 +tracksRegLiveness: true +body: | + bb.0: + + ; GCN-LABEL: name: s_ashr_i64 + ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: [[S_ASHR_I64_:%[0-9]+]]:sreg_64 = S_ASHR_I64 undef %2:sreg_64, [[COPY]], implicit-def $scc + %0:sreg_32 = COPY $src_flat_scratch_base_hi + %2:sreg_64 = S_ASHR_I64 undef %1:sreg_64, %0, implicit-def $scc +... + +--- +name: s_lshl_b64 +tracksRegLiveness: true +body: | + bb.0: + + ; GCN-LABEL: name: s_lshl_b64 + ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: [[S_LSHL_B64_:%[0-9]+]]:sreg_64 = S_LSHL_B64 undef %2:sreg_64, [[COPY]], implicit-def $scc + %0:sreg_32 = COPY $src_flat_scratch_base_hi + %2:sreg_64 = S_LSHL_B64 undef %1:sreg_64, %0, implicit-def $scc +... + +--- +name: s_lshr_b64 +tracksRegLiveness: true +body: | + bb.0: + + ; GCN-LABEL: name: s_lshr_b64 + ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: [[S_LSHR_B64_:%[0-9]+]]:sreg_64 = S_LSHR_B64 undef %2:sreg_64, [[COPY]], implicit-def $scc + %0:sreg_32 = COPY $src_flat_scratch_base_hi + %2:sreg_64 = S_LSHR_B64 undef %1:sreg_64, %0, implicit-def $scc +... + +--- +name: s_bfe_i64 +tracksRegLiveness: true +body: | + bb.0: + + ; GCN-LABEL: name: s_bfe_i64 + ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: [[S_BFE_I64_:%[0-9]+]]:sreg_64 = S_BFE_I64 undef %2:sreg_64, [[COPY]], implicit-def $scc + %0:sreg_32 = COPY $src_flat_scratch_base_hi + %2:sreg_64 = S_BFE_I64 undef %1:sreg_64, %0, implicit-def $scc +... + +--- +name: s_bfe_u64 +tracksRegLiveness: true +body: | + bb.0: + + ; GCN-LABEL: name: s_bfe_u64 + ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: [[S_BFE_U64_:%[0-9]+]]:sreg_64 = S_BFE_U64 undef %2:sreg_64, [[COPY]], implicit-def $scc + %0:sreg_32 = COPY $src_flat_scratch_base_hi + %2:sreg_64 = S_BFE_U64 undef %1:sreg_64, %0, implicit-def $scc +... + +--- +name: s_bfm_b64 +tracksRegLiveness: true +body: | + bb.0: + + ; GCN-LABEL: name: s_bfm_b64 + ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: [[S_BFM_B64_:%[0-9]+]]:sreg_64 = S_BFM_B64 [[COPY]], 1, implicit-def $scc + %0:sreg_32 = COPY $src_flat_scratch_base_hi + %1:sreg_64 = S_BFM_B64 %0, 1, implicit-def $scc +... + +--- +name: s_bitcmp0_b64 +tracksRegLiveness: true +body: | + bb.0: + + ; GCN-LABEL: name: s_bitcmp0_b64 + ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: S_BITCMP0_B64 undef %1:sreg_64, [[COPY]], implicit undef $scc, implicit-def $scc + %0:sreg_32 = COPY $src_flat_scratch_base_hi + S_BITCMP0_B64 undef %1:sreg_64, %0, implicit undef $scc, implicit-def $scc +... + +--- +name: s_bitcmp1_b64 +tracksRegLiveness: true +body: | + bb.0: + + ; GCN-LABEL: name: s_bitcmp1_b64 + ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: S_BITCMP1_B64 undef %1:sreg_64, [[COPY]], implicit undef $scc, implicit-def $scc + %0:sreg_32 = COPY $src_flat_scratch_base_hi + S_BITCMP1_B64 undef %1:sreg_64, %0, implicit undef $scc, implicit-def $scc +... + +--- +name: s_bitreplicate_b64_b32 +tracksRegLiveness: true +body: | + bb.0: + + ; GCN-LABEL: name: s_bitreplicate_b64_b32 + ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: [[S_BITREPLICATE_B64_B32_:%[0-9]+]]:sreg_64 = S_BITREPLICATE_B64_B32 [[COPY]], implicit-def $scc + %0:sreg_32 = COPY $src_flat_scratch_base_hi + %2:sreg_64 = S_BITREPLICATE_B64_B32 %0, implicit-def $scc +... + +--- +name: s_bitset0_b64 +tracksRegLiveness: true +body: | + bb.0: + + ; GCN-LABEL: name: s_bitset0_b64 + ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: [[S_BITSET0_B64_:%[0-9]+]]:sreg_64 = S_BITSET0_B64 [[COPY]], undef [[S_BITSET0_B64_]], implicit-def $scc + %0:sreg_32 = COPY $src_flat_scratch_base_hi + %1:sreg_64 = S_BITSET0_B64 %0, undef %1:sreg_64, implicit-def $scc +... + +--- +name: s_bitset1_b64 +tracksRegLiveness: true +body: | + bb.0: + + ; GCN-LABEL: name: s_bitset1_b64 + ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: [[S_BITSET1_B64_:%[0-9]+]]:sreg_64 = S_BITSET1_B64 [[COPY]], undef [[S_BITSET1_B64_]], implicit-def $scc + %0:sreg_32 = COPY $src_flat_scratch_base_hi + %1:sreg_64 = S_BITSET1_B64 %0, undef %1:sreg_64, implicit-def $scc +...