Skip to content

[flang][acc] Add TODO for cache directive lowering #170608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangzpgi merged 2 commits into from
Dec 4, 2025
Merged

[flang][acc] Add TODO for cache directive lowering #170608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f171f00
Add TODO for cache directive lowering
wangzpgi Dec 4, 2025
368980b
Merge branch 'main' into acctodo
wangzpgi Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions flang/lib/Lower/OpenACC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4787,6 +4787,8 @@ genACC(Fortran::lower::AbstractConverter &converter,
Fortran::semantics::SemanticsContext &semanticsContext,
const Fortran::parser::OpenACCCacheConstruct &cacheConstruct) {
fir::FirOpBuilder &builder = converter.getFirOpBuilder();
mlir::Location loc = converter.genLocation(cacheConstruct.source);
TODO(loc, "OpenACC cache directive");
Copy link
Contributor

@clementval clementval Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we keep the code after the TODO?

Copy link
Contributor Author

@wangzpgi wangzpgi Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR was auto-merged before I saw your comment. I will clean up in a separate PR. Thanks.

auto loopOp = builder.getRegion().getParentOfType<mlir::acc::LoopOp>();
auto crtPos = builder.saveInsertionPoint();
if (loopOp) {
Expand Down
15 changes: 15 additions & 0 deletions flang/test/Lower/OpenACC/Todo/acc-cache.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
! RUN: %not_todo_cmd bbc -fopenacc -emit-hlfir %s -o - 2>&1 | FileCheck %s

! CHECK: not yet implemented: OpenACC cache directive

subroutine test_cache()
integer, parameter :: n = 10
real, dimension(n) :: a, b
integer :: i

!$acc loop
do i = 1, n
!$acc cache(b)
a(i) = b(i)
end do
end subroutine
9 changes: 0 additions & 9 deletions flang/test/Lower/OpenACC/acc-loop.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,15 +359,6 @@ program acc_loop
! CHECK: acc.yield
! CHECK-NEXT: } attributes {inclusiveUpperbound = array<i1: true>, independent = [#acc.device_type<none>]}

!$acc loop
DO i = 1, n
!$acc cache(b)
a(i) = b(i)
END DO

! CHECK: %[[CACHE:.*]] = acc.cache varPtr(%{{.*}} : !fir.ref<!fir.array<10xf32>>) -> !fir.ref<!fir.array<10xf32>> {name = "b"}
! CHECK: acc.loop {{.*}} cache(%[[CACHE]] : !fir.ref<!fir.array<10xf32>>)

!$acc loop
do 100 i=0, n
100 continue
Expand Down
Loading