From ca4580a00305e5bf899b3ec0e36ccf7c5fe59969 Mon Sep 17 00:00:00 2001 From: Konrad Kleine Date: Thu, 4 Dec 2025 11:50:49 +0000 Subject: [PATCH] [Hexagon] Fix assignment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `VmpaIntID` was used in variable definition of `VmpaIntID`. ``` /home/fedora/src/llvm-project/main/llvm/lib/Target/Hexagon/HexagonGenWideningVecInstr.cpp: In member function ‘bool {anonymous}::HexagonGenWideningVecInstr::replaceWithVmpaIntrinsic(llvm::Instruction*, OPInfo*)’: /home/fedora/src/llvm-project/main/llvm/lib/Target/Hexagon/HexagonGenWideningVecInstr.cpp:843:41: warning: operation on ‘VmpaIntID’ may be undefined [-Wsequence-point] 843 | (NewResEltSize == 16) ? VmpaIntID = Intrinsic::hexagon_V6_vmpabus_128B | ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` This was introduced in #169559 --- llvm/lib/Target/Hexagon/HexagonGenWideningVecInstr.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/llvm/lib/Target/Hexagon/HexagonGenWideningVecInstr.cpp b/llvm/lib/Target/Hexagon/HexagonGenWideningVecInstr.cpp index 8df22ae6ebb06..f71ac03d3ea4e 100644 --- a/llvm/lib/Target/Hexagon/HexagonGenWideningVecInstr.cpp +++ b/llvm/lib/Target/Hexagon/HexagonGenWideningVecInstr.cpp @@ -839,9 +839,9 @@ bool HexagonGenWideningVecInstr::replaceWithVmpaIntrinsic(Instruction *Inst, NewVOP2 = IRB.CreateBitCast(NewVOP2, InType); Value *VecOP = IRB.CreateCall(ExtF, {NewVOP1, NewVOP2}); - Intrinsic::ID VmpaIntID = - (NewResEltSize == 16) ? VmpaIntID = Intrinsic::hexagon_V6_vmpabus_128B - : VmpaIntID = Intrinsic::hexagon_V6_vmpauhb_128B; + Intrinsic::ID VmpaIntID = (NewResEltSize == 16) + ? Intrinsic::hexagon_V6_vmpabus_128B + : Intrinsic::hexagon_V6_vmpauhb_128B; ExtF = Intrinsic::getOrInsertDeclaration(M, VmpaIntID); auto *ResType = FixedVectorType::get(getElementTy(NewResEltSize, IRB), NumElts);