[clang-tidy] Fix fragile test in read-parameters-from-file
#171033
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-clang-tidy @llvm/pr-subscribers-clang-tools-extra Author: mitchell (zeyi2) ChangesCommandLine.cpp treats single quote as literal characters on Windows, so the argument is parsed as a check named ' -*,llvm-namespace-comment ', which matches no existing checks, so no checks are enabled via the command line. Previously, the test passed because it fell back to the root Full diff: https://github.com/llvm/llvm-project/pull/171033.diff 1 Files Affected:
diff --git a/clang-tools-extra/test/clang-tidy/infrastructure/Inputs/param/parameters.txt b/clang-tools-extra/test/clang-tidy/infrastructure/Inputs/param/parameters.txt
index a6d8fa7ee299f..5cf5693664f53 100644
--- a/clang-tools-extra/test/clang-tidy/infrastructure/Inputs/param/parameters.txt
+++ b/clang-tools-extra/test/clang-tidy/infrastructure/Inputs/param/parameters.txt
@@ -1,2 +1,2 @@
--checks='-*,llvm-namespace-comment'
+-checks=-*,llvm-namespace-comment
--warnings-as-errors=llvm-namespace-comment
|
honeygoyal
pushed a commit
to honeygoyal/llvm-project
that referenced
this pull request
Dec 9, 2025
…1033) [CommandLine.cpp](https://github.com/llvm/llvm-project/blob/fb0400fe1f1f9e83f3148db8ce2c72ab5bc6728e/llvm/lib/Support/CommandLine.cpp#L940) treats single quote as literal characters on Windows, so the argument is parsed as a check named `' -*,llvm-namespace-comment '`, which matches no existing checks, so no checks are enabled via the command line. Previously, the test passed because it fell back to the root `.clang-tidy` configuration which enables `llvm-*`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommandLine.cpp treats single quote as literal characters on Windows, so the argument is parsed as a check named
' -*,llvm-namespace-comment ', which matches no existing checks, so no checks are enabled via the command line.Previously, the test passed because it fell back to the root
.clang-tidyconfiguration which enablesllvm-*.