[clang-tidy][NFC] Refactor fuchsia-multiple-inheritance
#171059
Merged
+41
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localspook
requested review from
EugeneZelenko,
HerrCai0907,
vbvictor,
zeyi2 and
zwuis
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
At the call site, it was just as much code to call this function as it is to inline it. This also avoids an out parameter.
Now all the interface criteria is in one place.
localspook
force-pushed
the
fuchsia-multiple-inheritance-refactor
branch
from
9284d78 to
b6017d5
Compare
zwuis
approved these changes
Dec 8, 2025
clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
Outdated
Show resolved
Hide resolved
clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
Outdated
Show resolved
Hide resolved
zeyi2
approved these changes
Dec 8, 2025
vbvictor
approved these changes
Dec 8, 2025
Contributor
vbvictor
left a comment
vbvictor
left a comment
There was a problem hiding this comment.
So this check now only located in "fuchsia" module.
I think we could have a regular misc- check for it instead, so more users can discover and use it.
Member
Maybe open another "rename" issue for this check? Update: see #171136 |
honeygoyal
pushed a commit
to honeygoyal/llvm-project
that referenced
this pull request
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've structured this PR as a series of independent commits, so it's probably easiest to review commit-by-commit. There's some subjectivity involved with refactoring, so if you think any of the changes is a downgrade, I'm happy to discuss it.