diff --git a/llvm/lib/Target/Hexagon/CMakeLists.txt b/llvm/lib/Target/Hexagon/CMakeLists.txt index 85ec5c7c2d45e..a0420ef5f0fe5 100644 --- a/llvm/lib/Target/Hexagon/CMakeLists.txt +++ b/llvm/lib/Target/Hexagon/CMakeLists.txt @@ -86,6 +86,7 @@ add_llvm_target(HexagonCodeGen HexagonInfo IPO MC + MIRParser Scalar SelectionDAG Support diff --git a/llvm/lib/Target/Hexagon/HexagonFrameLowering.cpp b/llvm/lib/Target/Hexagon/HexagonFrameLowering.cpp index df612262def5e..dd533b46a6e4e 100644 --- a/llvm/lib/Target/Hexagon/HexagonFrameLowering.cpp +++ b/llvm/lib/Target/Hexagon/HexagonFrameLowering.cpp @@ -1394,21 +1394,39 @@ bool HexagonFrameLowering::insertCSRSpillsInBlock(MachineBasicBlock &MBB, // Add live in registers. for (const CalleeSavedInfo &I : CSI) MBB.addLiveIn(I.getReg()); - return true; + } else { + for (const CalleeSavedInfo &I : CSI) { + MCRegister Reg = I.getReg(); + // Add live in registers. We treat eh_return callee saved register r0 - r3 + // specially. They are not really callee saved registers as they are not + // supposed to be killed. + bool IsKill = !HRI.isEHReturnCalleeSaveReg(Reg); + int FI = I.getFrameIdx(); + const TargetRegisterClass *RC = HRI.getMinimalPhysRegClass(Reg); + HII.storeRegToStackSlot(MBB, MI, Reg, IsKill, FI, RC, Register()); + if (IsKill) + MBB.addLiveIn(Reg); + } } - for (const CalleeSavedInfo &I : CSI) { - MCRegister Reg = I.getReg(); - // Add live in registers. We treat eh_return callee saved register r0 - r3 - // specially. They are not really callee saved registers as they are not - // supposed to be killed. - bool IsKill = !HRI.isEHReturnCalleeSaveReg(Reg); - int FI = I.getFrameIdx(); - const TargetRegisterClass *RC = HRI.getMinimalPhysRegClass(Reg); - HII.storeRegToStackSlot(MBB, MI, Reg, IsKill, FI, RC, Register()); - if (IsKill) - MBB.addLiveIn(Reg); + // Move PS_aligna to after all CSR spills (both inline and spill-function + // paths). PS_aligna initializes the AP register (e.g. R16) with an aligned + // value derived from FP. Since AP is a callee-saved register, its original + // value must be saved before it is overwritten, and it must be defined + // before any AP-relative stack accesses. + // MI points to the first non-spill instruction; all spills are before it. + auto &HFI = *MF.getSubtarget().getFrameLowering(); + if (const MachineInstr *AlignaI = HFI.getAlignaInstr(MF)) { + MachineInstr *AI = const_cast(AlignaI); + // PS_aligna is always created in EntryBB during ISEL. Since PS_aligna + // causes needsStackFrame() to return true, EntryBB will be included in + // the set of blocks needing a frame. Because EntryBB dominates all blocks, + // shrink-wrapping will always place PrologB at EntryBB when PS_aligna + // exists. Therefore, this assertion should always hold. + assert(AI->getParent() == &MBB && "PS_aligna not in prologue block"); + MBB.splice(MI, AI->getParent(), AI->getIterator()); } + return true; } diff --git a/llvm/lib/Target/Hexagon/HexagonMachineFunctionInfo.cpp b/llvm/lib/Target/Hexagon/HexagonMachineFunctionInfo.cpp index 539db8f55005a..e1444416a020c 100644 --- a/llvm/lib/Target/Hexagon/HexagonMachineFunctionInfo.cpp +++ b/llvm/lib/Target/Hexagon/HexagonMachineFunctionInfo.cpp @@ -7,6 +7,9 @@ //===----------------------------------------------------------------------===// #include "HexagonMachineFunctionInfo.h" +#include "llvm/CodeGen/MachineRegisterInfo.h" +#include "llvm/CodeGen/TargetRegisterInfo.h" +#include "llvm/Support/raw_ostream.h" using namespace llvm; @@ -19,3 +22,24 @@ MachineFunctionInfo *HexagonMachineFunctionInfo::clone( const { return DestMF.cloneInfo(*this); } + +static yaml::StringValue regToString(Register Reg, + const TargetRegisterInfo &TRI) { + yaml::StringValue Dest; + if (Reg.isValid()) { + raw_string_ostream OS(Dest.Value); + OS << printReg(Reg, &TRI); + } + return Dest; +} + +yaml::HexagonFunctionInfo::HexagonFunctionInfo( + const llvm::HexagonMachineFunctionInfo &MFI, const TargetRegisterInfo &TRI) + : StackAlignBaseReg(regToString(MFI.getStackAlignBaseReg(), TRI)) {} + +void yaml::HexagonFunctionInfo::mappingImpl(yaml::IO &YamlIO) { + MappingTraits::mapping(YamlIO, *this); +} + +void HexagonMachineFunctionInfo::initializeBaseYamlFields( + const yaml::HexagonFunctionInfo &YamlMFI) {} diff --git a/llvm/lib/Target/Hexagon/HexagonMachineFunctionInfo.h b/llvm/lib/Target/Hexagon/HexagonMachineFunctionInfo.h index c5df02fa3b89c..6349a1a07fc55 100644 --- a/llvm/lib/Target/Hexagon/HexagonMachineFunctionInfo.h +++ b/llvm/lib/Target/Hexagon/HexagonMachineFunctionInfo.h @@ -9,11 +9,16 @@ #ifndef LLVM_LIB_TARGET_HEXAGON_HEXAGONMACHINEFUNCTIONINFO_H #define LLVM_LIB_TARGET_HEXAGON_HEXAGONMACHINEFUNCTIONINFO_H +#include "llvm/CodeGen/MIRYamlMapping.h" #include "llvm/CodeGen/MachineFunction.h" #include namespace llvm { +namespace yaml { +struct HexagonFunctionInfo; +} // end namespace yaml + namespace Hexagon { const unsigned int StartPacket = 0x1; @@ -48,6 +53,8 @@ class HexagonMachineFunctionInfo : public MachineFunctionInfo { const DenseMap &Src2DstMBB) const override; + void initializeBaseYamlFields(const yaml::HexagonFunctionInfo &YamlMFI); + unsigned getSRetReturnReg() const { return SRetReturnReg; } void setSRetReturnReg(unsigned Reg) { SRetReturnReg = Reg; } @@ -87,6 +94,28 @@ class HexagonMachineFunctionInfo : public MachineFunctionInfo { Register getStackAlignBaseReg() const { return StackAlignBaseReg; } }; +namespace yaml { + +/// Hexagon-specific MachineFunction properties for YAML serialization. +struct HexagonFunctionInfo final : public yaml::MachineFunctionInfo { + StringValue StackAlignBaseReg; + + HexagonFunctionInfo() = default; + HexagonFunctionInfo(const llvm::HexagonMachineFunctionInfo &MFI, + const TargetRegisterInfo &TRI); + + void mappingImpl(yaml::IO &YamlIO) override; + ~HexagonFunctionInfo() override = default; +}; + +template <> struct MappingTraits { + static void mapping(IO &YamlIO, HexagonFunctionInfo &MFI) { + YamlIO.mapOptional("stackAlignBaseReg", MFI.StackAlignBaseReg); + } +}; + +} // end namespace yaml + } // end namespace llvm #endif // LLVM_LIB_TARGET_HEXAGON_HEXAGONMACHINEFUNCTIONINFO_H diff --git a/llvm/lib/Target/Hexagon/HexagonTargetMachine.cpp b/llvm/lib/Target/Hexagon/HexagonTargetMachine.cpp index d9824a3154093..0de007fb93e02 100644 --- a/llvm/lib/Target/Hexagon/HexagonTargetMachine.cpp +++ b/llvm/lib/Target/Hexagon/HexagonTargetMachine.cpp @@ -20,6 +20,7 @@ #include "HexagonTargetTransformInfo.h" #include "HexagonVectorLoopCarriedReuse.h" #include "TargetInfo/HexagonTargetInfo.h" +#include "llvm/CodeGen/MIRParser/MIParser.h" #include "llvm/CodeGen/Passes.h" #include "llvm/CodeGen/TargetPassConfig.h" #include "llvm/CodeGen/VLIWMachineScheduler.h" @@ -289,6 +290,41 @@ MachineFunctionInfo *HexagonTargetMachine::createMachineFunctionInfo( Allocator, F, STI); } +yaml::MachineFunctionInfo * +HexagonTargetMachine::createDefaultFuncInfoYAML() const { + return new yaml::HexagonFunctionInfo(); +} + +yaml::MachineFunctionInfo * +HexagonTargetMachine::convertFuncInfoToYAML(const MachineFunction &MF) const { + const auto *MFI = MF.getInfo(); + const auto &TRI = *MF.getSubtarget().getRegisterInfo(); + return new yaml::HexagonFunctionInfo(*MFI, TRI); +} + +bool HexagonTargetMachine::parseMachineFunctionInfo( + const yaml::MachineFunctionInfo &MFI_, PerFunctionMIParsingState &PFS, + SMDiagnostic &Error, SMRange &SourceRange) const { + const auto &YamlMFI = static_cast(MFI_); + MachineFunction &MF = PFS.MF; + HexagonMachineFunctionInfo *MFI = MF.getInfo(); + + MFI->initializeBaseYamlFields(YamlMFI); + + // Parse StackAlignBaseReg register name + if (!YamlMFI.StackAlignBaseReg.Value.empty()) { + Register Reg; + if (parseNamedRegisterReference(PFS, Reg, YamlMFI.StackAlignBaseReg.Value, + Error)) { + SourceRange = YamlMFI.StackAlignBaseReg.SourceRange; + return true; + } + MFI->setStackAlignBaseReg(Reg); + } + + return false; +} + HexagonTargetMachine::~HexagonTargetMachine() = default; ScheduleDAGInstrs * diff --git a/llvm/lib/Target/Hexagon/HexagonTargetMachine.h b/llvm/lib/Target/Hexagon/HexagonTargetMachine.h index 48e0c08c0cab2..98a21bbba4794 100644 --- a/llvm/lib/Target/Hexagon/HexagonTargetMachine.h +++ b/llvm/lib/Target/Hexagon/HexagonTargetMachine.h @@ -47,6 +47,14 @@ class HexagonTargetMachine : public CodeGenTargetMachineImpl { createMachineFunctionInfo(BumpPtrAllocator &Allocator, const Function &F, const TargetSubtargetInfo *STI) const override; + yaml::MachineFunctionInfo *createDefaultFuncInfoYAML() const override; + yaml::MachineFunctionInfo * + convertFuncInfoToYAML(const MachineFunction &MF) const override; + bool parseMachineFunctionInfo(const yaml::MachineFunctionInfo &, + PerFunctionMIParsingState &PFS, + SMDiagnostic &Error, + SMRange &SourceRange) const override; + bool isNoopAddrSpaceCast(unsigned SrcAS, unsigned DestAS) const override { return true; } diff --git a/llvm/test/CodeGen/Hexagon/aligna-prologue-expansion.mir b/llvm/test/CodeGen/Hexagon/aligna-prologue-expansion.mir new file mode 100644 index 0000000000000..2a6dbefb77a2a --- /dev/null +++ b/llvm/test/CodeGen/Hexagon/aligna-prologue-expansion.mir @@ -0,0 +1,99 @@ +# RUN: llc -mtriple=hexagon -run-pass prologepilog %s -o - | FileCheck %s +# RUN: llc -mtriple=hexagon -run-pass prologepilog -spill-func-threshold=0 %s -o - | FileCheck --check-prefix=SPILL-FUNC %s +# RUN: llc -mtriple=hexagon -run-pass prologepilog -verify-machineinstrs %s -o - | FileCheck %s +# +# Verify that PS_aligna is placed AFTER all CSR spills. +# +# CHECK-LABEL: name: test_aligna_expansion +# CHECK: machineFunctionInfo: +# CHECK-NEXT: stackAlignBaseReg: '$r16' +# CHECK: S2_allocframe +# CHECK: S2_storerd_io $r30, -8 +# CHECK: S2_storerd_io $r30, -16 +# CHECK: S2_storerd_io $r30, -24 +# CHECK: S2_storerd_io $r30, -32 +# CHECK: S2_storerd_io $r30, -40 +# CHECK: S2_storerd_io $r30, -48 +# CHECK: PS_aligna +# CHECK-NOT: S2_storerd_io +# +# SPILL-FUNC-LABEL: name: test_aligna_expansion +# SPILL-FUNC: machineFunctionInfo: +# SPILL-FUNC-NEXT: stackAlignBaseReg: '$r16' +# SPILL-FUNC: S2_allocframe +# SPILL-FUNC: SAVE_REGISTERS_CALL_V4 +# SPILL-FUNC: PS_aligna +# SPILL-FUNC-NOT: SAVE_REGISTERS_CALL_V4 + +--- | + declare void @external_func() + define void @test_aligna_expansion() { ret void } +... + +--- +name: test_aligna_expansion +alignment: 16 +tracksRegLiveness: true +machineFunctionInfo: + stackAlignBaseReg: '$r16' +frameInfo: + maxAlignment: 128 + adjustsStack: true + hasCalls: true + maxCallFrameSize: 4294967295 +stack: + - { id: 0, name: '', type: variable-sized, offset: 0, alignment: 128 } + - { id: 1, name: '', type: spill-slot, offset: 0, size: 4, alignment: 4 } +body: | + bb.0: + successors: %bb.1(0x80000000) + liveins: $r0, $r1, $r2, $r3, $r4, $r5 + + renamable $r17 = COPY $r0 + renamable $r6 = nuw A2_addi killed $r0, 7 + renamable $r6 = A2_andir killed renamable $r6, -8 + S2_storeri_io %stack.1, 0, killed $r5 :: (store (s32) into %stack.1) + renamable $r19 = COPY killed $r4 + renamable $r20 = COPY killed $r3 + renamable $r21 = COPY killed $r2 + renamable $r22 = COPY killed $r1 + $r16 = PS_aligna 128, implicit killed $r30 + renamable $r25 = A2_tfrsi 0 + renamable $r2 = A2_tfrsi 0 + renamable $r23 = PS_alloca killed renamable $r6, 128, implicit-def dead $r29 + + bb.1: + successors: %bb.2(0x80000000) + liveins: $r2, $r17, $r19, $r20, $r21, $r22, $r23, $r25 + + renamable $r24 = A2_or killed renamable $r2, renamable $r19 + renamable $r26 = A2_tfrsi 0 + renamable $r27 = COPY renamable $r22 + renamable $r18 = A2_tfrsi 0 + + bb.2: + successors: %bb.2(0x7c000000), %bb.3(0x04000000) + liveins: $r17, $r18, $r19, $r20, $r21, $r22, $r23, $r24, $r25, $r26, $r27 + + renamable $r2 = A2_min renamable $r27, renamable $r25 + ADJCALLSTACKDOWN 0, 0, implicit-def $r29, implicit-def dead $r30, implicit killed $r31, implicit killed $r30, implicit $r29 + $r0 = COPY renamable $r23 + $r1 = COPY renamable $r20 + $r3 = COPY renamable $r24 + renamable $r2 = A2_add killed renamable $r2, renamable $r26 + renamable $r18 = A2_add killed renamable $r18, renamable $r22 + S2_storeri_io renamable $r21, 0, renamable $r17 + J2_call @external_func, hexagoncsr, implicit-def dead $pc, implicit-def dead $r31, implicit $r29, implicit killed $r0, implicit killed $r1, implicit killed $r2, implicit killed $r3, implicit-def $r29 + renamable $p0 = C2_cmpgti renamable $r18, -1 + ADJCALLSTACKUP 0, 0, implicit-def dead $r29, implicit-def dead $r30, implicit-def dead $r31, implicit killed $r29 + renamable $r27 = A2_add killed renamable $r27, renamable $r22 + renamable $r26 = A2_sub killed renamable $r26, renamable $r22 + J2_jumpf killed renamable $p0, %bb.2, implicit-def $pc + + bb.3: + successors: %bb.1(0x80000000) + liveins: $r17, $r19, $r20, $r21, $r22, $r23, $r25 + + renamable $r2 = L2_loadri_io %stack.1, 0 :: (load (s32) from %stack.1) + J2_jump %bb.1, implicit-def $pc +...