[Docs] Update coding standard for TD files#200848
Merged
Merged
Conversation
This PR proposes an update to the coding standards document to make explicit that we do not want unnecessary formatting changes to TD files. This is in response to this merged PR (llvm#199346), which lead to this RFC (https://discourse.llvm.org/t/80-column-limit-for-td-files/90950/).
rengolin
requested review from
AaronBallman,
Endilll,
arsenm,
ftynse,
petrhosek,
shiltian and
tstellar
Endilll
reviewed
Jun 1, 2026
Endilll
left a comment
Endilll
left a comment
Contributor
There was a problem hiding this comment.
CC @AaronBallman I remember this was a pain point for you.
Contributor
|
I'm fine with this change. AFAIK, we don't really enforce this, and there are plenty of target-related |
Co-authored-by: Vlad Serebrennikov <serebrennikov.vladislav@gmail.com>
lenary
approved these changes
Jun 1, 2026
lenary
left a comment
lenary
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for documenting that we don't clang-format tablegen.
I recall the exclusion I added was LLVM-only but maybe other sub-projects also have it now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes an update to the coding standards document to make explicit that we do not want unnecessary formatting changes to TD files.
This is in response to this merged PR (#199346), which lead to this RFC (https://discourse.llvm.org/t/80-column-limit-for-td-files/90950/).