[libc++][C++20 modules] Fixes CMake include paths. #65079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldionne
requested changes
Aug 29, 2023
philnik777
added
the
libc++
ldionne
approved these changes
Aug 31, 2023
|
LGTM but can you please poke the CI again to get a green run? |
|
I think the workflow we want is that you rebase your patch on top of |
mordante
force-pushed
the
module_include_paths
branch
from
f1e9c74 to
4aacb5b
Compare
That indeed does the trick. FYI the existing libc++ buildkite CI job got, as wanted, cancelled. |
When the modules are used in a bootstrap build the paths
${LIBCXX_GENERATED_INCLUDE_DIR} and ${LIBCXX_GENERATED_INCLUDE_TARGET_DIR}
have a different value and both are needed to build modules.
This issue has been reported on Slack.
mordante
force-pushed
the
module_include_paths
branch
from
4aacb5b to
c7dead0
Compare
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
When the modules are used in a bootstrap build the paths
${LIBCXX_GENERATED_INCLUDE_DIR} and
${LIBCXX_GENERATED_INCLUDE_TARGET_DIR} have a different value and both
are needed to build modules.
This issue has been reported on Slack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the modules are used in a bootstrap build the paths ${LIBCXX_GENERATED_INCLUDE_DIR} and ${LIBCXX_GENERATED_INCLUDE_TARGET_DIR} have a different value and both are needed to build modules.
This issue has been reported on Slack.