[Parse] Split incremental-extensions #65683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The preprocessor `IncrementalProcessing` option was being used to control whether or not to teardown the lexer or run the end of translation unit action. In D127284 this was merged with `-fincremental-extensions`, which also changes top level parsing. Split these again so that the former behavior can be achieved without the latter (ie. to allow managing lifetime without also changing parsing). Resolves rdar://113406310.
github-actions
bot
added
the
clang:frontend
|
Seems Swift wasn't the only project to run into this, eg. #62413 (comment). Any thoughts on cherry-picking this to the release branch as well? |
cor3ntin
reviewed
Sep 8, 2023
cor3ntin
approved these changes
Sep 8, 2023
vgvassilev
approved these changes
Sep 8, 2023
It's in the appropriate branches in our fork, so it's fine for us either way. I suggested it more because of #62413 than anything else. |
bnbarham
added a commit
to bnbarham/llvm-project
that referenced
this pull request
Sep 13, 2023
This reverts commit c95a0c9. llvm#65683 split `-fincremental-extensions` and `IncrementalProcessing` such that `IncrementalProcessing` can be used to extend the lifetime of various datastructures without parsing changes. LLDB really should not be parsing any differently to a regular compile, so switch back to using just `IncrementalProcessing`.
This was referenced Sep 13, 2023
Closed
bnbarham
added a commit
to bnbarham/llvm-project
that referenced
this pull request
Sep 14, 2023
Re-applies llvm#65683 with a fix to always run `Actions.ActOnEndOfTranslationUnit` regardless of incremental processing.
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
The preprocessor `IncrementalProcessing` option was being used to control whether or not to teardown the lexer or run the end of translation unit action. In D127284 this was merged with `-fincremental-extensions`, which also changes top level parsing. Split these again so that the former behavior can be achieved without the latter (ie. to allow managing lifetime without also changing parsing). Resolves rdar://113406310.
bnbarham
added a commit
that referenced
this pull request
Sep 21, 2023
Re-applies #65683 with a fix to always run `Actions.ActOnEndOfTranslationUnit` regardless of incremental processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preprocessor
IncrementalProcessingoption was being used to control whether or not to teardown the lexer or run the end of translation unit action. In D127284 this was merged with-fincremental-extensions, which also changes top level parsing.Split these again so that the former behavior can be achieved without the latter (ie. to allow managing lifetime without also changing parsing).
Resolves rdar://113406310.