Nice work!

Jump to conversation

Unresolved conversations (0)

Nice work!

All of your conversations have been resolved.

Resolved conversations (7)

I think the offset should be `int64_t` and use `trySExtValue()` here. GEP offsets are signed. (Mainly for clarify, I think it will not make a functional difference?)

llvm/lib/Transforms/Scalar/EarlyCSE.cpp

nit: Use `auto *` with `cast<>`.

llvm/lib/Transforms/Scalar/EarlyCSE.cpp

The indents in these functions look wrong -- clang-format?

llvm/lib/Transforms/Scalar/EarlyCSE.cpp

Use std::optional instead?

llvm/lib/Transforms/Scalar/EarlyCSE.cpp

```suggestion unsigned DenseMapInfo<GEPValue>::getHashValue(const GEPValue &Val) { ``` Here and elsewhere.

llvm/lib/Transforms/Scalar/EarlyCSE.cpp

nit: Avoid duplicate getIndexTypeSizeInBits() call (can't have different bitwidths if the pointer operand is the same)

llvm/lib/Transforms/Scalar/EarlyCSE.cpp

nit: getPointerOperand().

llvm/lib/Transforms/Scalar/EarlyCSE.cpp