diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst index 43fb725c78ea4..3b35f2d47480d 100644 --- a/clang/docs/ReleaseNotes.rst +++ b/clang/docs/ReleaseNotes.rst @@ -455,6 +455,10 @@ Bug Fixes in This Version cannot be used with ``Release`` mode builds. (`#68237 `_). - Fix crash in evaluating ``constexpr`` value for invalid template function. Fixes (`#68542 `_) +- Clang will correctly evaluate ``noexcept`` expression for template functions + of template classes. Fixes + (`#68543 `_, + `#42496 `_) - Fixed an issue when a shift count larger than ``__INT64_MAX__``, in a right shift operation, could result in missing warnings about ``shift count >= width of type`` or internal compiler error. diff --git a/clang/lib/Sema/SemaTemplateDeduction.cpp b/clang/lib/Sema/SemaTemplateDeduction.cpp index 8f115f2177846..0b3f0247ea3be 100644 --- a/clang/lib/Sema/SemaTemplateDeduction.cpp +++ b/clang/lib/Sema/SemaTemplateDeduction.cpp @@ -3367,7 +3367,14 @@ Sema::TemplateDeductionResult Sema::SubstituteExplicitTemplateArguments( SmallVector ExceptionStorage; if (getLangOpts().CPlusPlus17 && SubstExceptionSpec(Function->getLocation(), EPI.ExceptionSpec, - ExceptionStorage, MLTAL)) + ExceptionStorage, + getTemplateInstantiationArgs( + FunctionTemplate, nullptr, /*Final=*/true, + /*Innermost=*/SugaredExplicitArgumentList, + /*RelativeToPrimary=*/false, + /*Pattern=*/nullptr, + /*ForConstraintInstantiation=*/false, + /*SkipForSpecialization=*/true))) return TDK_SubstitutionFailure; *FunctionType = BuildFunctionType(ResultType, ParamTypes, diff --git a/clang/lib/Sema/SemaTemplateInstantiate.cpp b/clang/lib/Sema/SemaTemplateInstantiate.cpp index effc97a033c5e..e09897318ba98 100644 --- a/clang/lib/Sema/SemaTemplateInstantiate.cpp +++ b/clang/lib/Sema/SemaTemplateInstantiate.cpp @@ -1335,6 +1335,11 @@ namespace { /// declaration. NamedDecl *TransformFirstQualifierInScope(NamedDecl *D, SourceLocation Loc); + bool TransformExceptionSpec(SourceLocation Loc, + FunctionProtoType::ExceptionSpecInfo &ESI, + SmallVectorImpl &Exceptions, + bool &Changed); + /// Rebuild the exception declaration and register the declaration /// as an instantiated local. VarDecl *RebuildExceptionDecl(VarDecl *ExceptionDecl, @@ -1617,6 +1622,18 @@ Decl *TemplateInstantiator::TransformDefinition(SourceLocation Loc, Decl *D) { return Inst; } +bool TemplateInstantiator::TransformExceptionSpec( + SourceLocation Loc, FunctionProtoType::ExceptionSpecInfo &ESI, + SmallVectorImpl &Exceptions, bool &Changed) { + if (ESI.Type == EST_Uninstantiated) { + ESI.NoexceptExpr = cast(ESI.SourceTemplate->getType()) + ->getNoexceptExpr(); + ESI.Type = EST_DependentNoexcept; + Changed = true; + } + return inherited::TransformExceptionSpec(Loc, ESI, Exceptions, Changed); +} + NamedDecl * TemplateInstantiator::TransformFirstQualifierInScope(NamedDecl *D, SourceLocation Loc) { @@ -2684,8 +2701,6 @@ bool Sema::SubstExceptionSpec(SourceLocation Loc, FunctionProtoType::ExceptionSpecInfo &ESI, SmallVectorImpl &ExceptionStorage, const MultiLevelTemplateArgumentList &Args) { - assert(ESI.Type != EST_Uninstantiated); - bool Changed = false; TemplateInstantiator Instantiator(*this, Args, Loc, DeclarationName()); return Instantiator.TransformExceptionSpec(Loc, ESI, ExceptionStorage, diff --git a/clang/test/SemaCXX/dependent-noexcept-uninstantiated.cpp b/clang/test/SemaCXX/dependent-noexcept-uninstantiated.cpp new file mode 100644 index 0000000000000..ddb2698902275 --- /dev/null +++ b/clang/test/SemaCXX/dependent-noexcept-uninstantiated.cpp @@ -0,0 +1,11 @@ +// RUN: %clang_cc1 -fsyntax-only -std=c++17 %s +// expected-no-diagnostics + +using A = int; +using B = char; + +template struct C { + template void f0() noexcept(sizeof(T) == sizeof(A) && sizeof(V) == sizeof(B)) {} +}; + +void (C::*tmp1)() noexcept = &C::f0;