Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenMP][Archer] Do not check for column numbers in backtraces #70075

Merged
merged 1 commit into from Oct 25, 2023

Conversation

iii-i
Copy link
Member

@iii-i iii-i commented Oct 24, 2023

TSan can show only line numbers on some platforms, e.g., SystemZ. Skip checking the column numbers; line numbers should be enough to verify that race detection is working.

TSan can show only line numbers on some platforms, e.g., SystemZ.
Skip checking the column numbers; line numbers should be enough to
verify that race detection is working.
@llvmbot llvmbot added openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime labels Oct 24, 2023
@jprotze jprotze self-requested a review October 25, 2023 11:21
Copy link
Collaborator

@jprotze jprotze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jprotze jprotze merged commit f7fc98a into llvm:main Oct 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants