Jump to conversation
Unresolved conversations (5)
@alexey-bataev alexey-bataev Nov 13, 2023
Maybe keep the version of the ACC in this value instead of having a separate string field, just like OpenMP does? 0 means th support is disabled, non-zero - supported version number.
clang/lib/Frontend/CompilerInvocation.cpp
erichkeane
@alexey-bataev alexey-bataev Nov 13, 2023
```suggestion if (Value.getAsInteger(10, Version)) A->renderAsInput(Args, CmdArgs); else D.Diag(diag::err_drv_clang_unsupported) << Value; ```
Outdated
clang/lib/Driver/ToolChains/Clang.cpp
erichkeane
@alexey-bataev alexey-bataev Nov 13, 2023
Why do you need this form? Is not EQ form is enough?
clang/include/clang/Driver/Options.td
erichkeane
@alexey-bataev alexey-bataev Nov 7, 2023
Why do you need this new option fexperimental-openacc-macro-override? Can you just rely on -D_OPENACC instead?
clang/test/Driver/openacc.c
erichkeane
@alexey-bataev alexey-bataev Nov 7, 2023
It is unused, need to remove it for now.
Outdated
clang/include/clang/Parse/Parser.h
alexey-bataev erichkeane
Resolved conversations (3)
@bcardosolopes bcardosolopes Nov 1, 2023
How does the interaction between using both `-fopenmp` and `-fopenacc` at the same time should look like? One takes precedence? Or should it be rejected?
clang/test/Driver/openacc.c
bcardosolopes erichkeane
@bcardosolopes bcardosolopes Nov 1, 2023
This probably deserves a test akin to `-E -dM` and FileCheck for the macro.
clang/lib/Frontend/InitPreprocessor.cpp
erichkeane
@bcardosolopes bcardosolopes Nov 1, 2023
Does `Directives` need to be capitalized?
Outdated
...clude/clang/Basic/DiagnosticParseKinds.td
erichkeane