Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenMP] Fix building for 32-bit DragonFly, NetBSD, OpenBSD #70527

Merged
merged 1 commit into from
Oct 28, 2023
Merged

[OpenMP] Fix building for 32-bit DragonFly, NetBSD, OpenBSD #70527

merged 1 commit into from
Oct 28, 2023

Conversation

brad0
Copy link
Contributor

@brad0 brad0 commented Oct 28, 2023 •
edited
Loading

Fixing #error "Unknown or unsupported OS"

@llvmbot llvmbot added the openmp:libomp OpenMP host runtime label Oct 28, 2023
@github-actions
Copy link

github-actions bot commented Oct 28, 2023 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@shiltian
Copy link
Contributor

The changes look fine but can you detail what to be fixed?

@brad0
Copy link
Contributor Author

brad0 commented Oct 28, 2023

The changes look fine but can you detail what to be fixed?

I am not sure I fully understand what you're asking, but without the patch you will hit #error "Unknown or unsupported OS" on the 32-bit archs.

shiltian
shiltian approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@shiltian shiltian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's the part I'd prefer to put into commit message.
You can do it when you commit the changes.

@brad0
[OpenMP] Fix building for 32-bit DragonFly, NetBSD, OpenBSD
4cc2327 
Fixing #error "Unknown or unsupported OS"
@brad0 brad0 merged commit 223852a into llvm:main Oct 28, 2023
3 checks passed
@brad0 brad0 deleted the openmp_32bit branch October 28, 2023 02:53
@brad0 brad0 mentioned this pull request Oct 28, 2023
Closed
tru pushed a commit that referenced this pull request Oct 31, 2023
@brad0 @tru
[OpenMP] Fix building for 32-bit DragonFly, NetBSD, OpenBSD (#70527)
9d0ca25 
Fixing ```#error "Unknown or unsupported OS"```

(cherry picked from commit 223852a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiltian shiltian shiltian approved these changes

Assignees
No one assigned
Labels
openmp:libomp OpenMP host runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brad0 @shiltian @llvmbot