[libc++][NFC] Update ignore_format for expected tests #70869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After changes to <expected>, more test files are now properly formatted.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Will Hawkins (hawkinsw) ChangesAfter changes to <expected>, more test files are now properly formatted. Full diff: https://github.com/llvm/llvm-project/pull/70869.diff 1 Files Affected:
diff --git a/libcxx/utils/data/ignore_format.txt b/libcxx/utils/data/ignore_format.txt
index d4afd8c87350fd1..cf6dca7cd7d3c68 100644
--- a/libcxx/utils/data/ignore_format.txt
+++ b/libcxx/utils/data/ignore_format.txt
@@ -6257,7 +6257,6 @@ libcxx/test/std/utilities/expected/expected.expected/observers/deref.pass.cpp
libcxx/test/std/utilities/expected/expected.expected/observers/error.pass.cpp
libcxx/test/std/utilities/expected/expected.expected/observers/has_value.pass.cpp
libcxx/test/std/utilities/expected/expected.expected/observers/value.pass.cpp
-libcxx/test/std/utilities/expected/expected.expected/swap/member.swap.pass.cpp
libcxx/test/std/utilities/expected/expected.unexpected/ctad.compile.pass.cpp
libcxx/test/std/utilities/expected/expected.unexpected/ctor/ctor.inplace.pass.cpp
libcxx/test/std/utilities/expected/expected.unexpected/ctor/ctor.move.pass.cpp
@@ -6277,7 +6276,6 @@ libcxx/test/std/utilities/expected/expected.void/observers/deref.pass.cpp
libcxx/test/std/utilities/expected/expected.void/observers/error.pass.cpp
libcxx/test/std/utilities/expected/expected.void/observers/has_value.pass.cpp
libcxx/test/std/utilities/expected/expected.void/swap/free.swap.pass.cpp
-libcxx/test/std/utilities/expected/expected.void/swap/member.swap.pass.cpp
libcxx/test/std/utilities/format/format.arguments/format.args/get.pass.cpp
libcxx/test/std/utilities/format/format.arguments/format.args/types.compile.pass.cpp
libcxx/test/std/utilities/format/format.arguments/format.arg/visit_format_arg.pass.cpp
|
My pleasure. I will land as soon as the checks complete, if that's okay! |
|
I'm landing this now, since the relevant tests passed and this is breaking everybody's CI pipeline. |
|
Thanks!! I didn't want to be presumptuous and jump the gun! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After changes to , more test files are now properly formatted.