[openmp] Clarify error message if TSan is missing #70916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For an uninformed user, the error message might refer to a missing "TSan stopping operation", rather than indicating that TSan is missing **and therefore** operation is stopped.
llvmbot
added
openmp:libomp
jons-pf
changed the title
arsenm
approved these changes
Nov 1, 2023
|
@arsenm May I ask if this could be merged in the near future? As far as I understand, the proposed change is approved? |
Usually people merge their own patches, so in general you should ask if you need someone to push for you |
|
Sorry, I was not aware of this. Thanks for pushing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an uninformed user, the error message might refer to a missing "TSan stopping operation", rather than indicating that TSan is missing and therefore operation is stopped.