[OpenMP] Add an 'stddef.h' include to 'omp.h' #73876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We use `size_t` internally in the omp.h header, which is normally provided by `stdlib.h` which is already included. Howevever, some cases when using `-ffreestanding` can result in this not being defined via `stdlib.h`. This patch simply adds an explicit inclusion of this header, which is provided by the `clang` resource directory, to resolve this in all cases.
jhuber6
requested review from
carlobertolli,
jdoerfert,
JonChesterfield,
jpeyton52 and
shiltian
|
Can we test this with a lit test? |
It's pretty trivial, but I can make a freestanding test if you want. |
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Dec 7, 2023
Local branch amd-gfx 30878b6 Merged main:fc19424d1d6d into amd-gfx:a5dbf9439804 Remote branch main 8b9a6af [OpenMP] Add an stddef.h include to omp.h (llvm#73876)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We use
size_tinternally in the omp.h header, which is normallyprovided by
stdlib.hwhich is already included. Howevever, some caseswhen using
-ffreestandingcan result in this not being defined viastdlib.h. This patch simply adds an explicit inclusion of this header,which is provided by the
clangresource directory, to resolve this inall cases.