Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (3)
@lntue lntue Dec 5, 2023
Look like this still generates warnings in gcc: https://godbolt.org/z/fTrT3hPx4
Outdated
libc/src/__support/wctype_utils.h
nickdesaulniers SchrodingerZhu
lntue
@michaelrj-google michaelrj-google Dec 5, 2023
nit: remove "where", put a period between "type" and "different".
Outdated
libc/src/__support/wctype_utils.h
nickdesaulniers
@SchrodingerZhu SchrodingerZhu Dec 5, 2023
Would `(c & ~127) != 0` be better? (maybe not straightforward enough)
Outdated
libc/src/__support/wctype_utils.h
nickdesaulniers lntue
michaelrj-google