Jump to conversation
Unresolved conversations (6)
@huixie90 huixie90 Dec 7, 2023
Nothing to do with your patch, just wanted to point out that we don’t seem to have tests to test the default argument. (you don’t need to do it as this is nothing to do with the bug you are fixing) template<bool _OtherConst = !_Const>
libcxx/include/__ranges/take_view.h
JMazurkiewicz
@huixie90 huixie90 Dec 7, 2023
Nit: Since you are refactoring the test. Could you add another assert where the expression on the right actually return “false” ?
Outdated
...ange.take/range.take.sentinel/eq.pass.cpp
JMazurkiewicz
@huixie90 huixie90 Dec 7, 2023
Not attached to this line. What is the reason to rename the folder? The folder name is meant to itch the spec section id
...ge.take/range.take.sentinel/base.pass.cpp
Zingam JMazurkiewicz
@huixie90 huixie90 Dec 7, 2023
This line looks exactly the same as the line above
Outdated
...ange.take/range.take.sentinel/eq.pass.cpp
JMazurkiewicz
@huixie90 huixie90 Dec 7, 2023
Similarly, I also found the FancyNonSimpleView name a bit misleading. It is actually less fancier than the NonSimpleView. IIUC, NonSimpleView is the cross-const comparable view, and FancyNonSimpleView is the non-cross-const-comparable view
Outdated
...ange.take/range.take.sentinel/eq.pass.cpp
JMazurkiewicz
@huixie90 huixie90 Dec 7, 2023
I found the name StrictSentinel a bit confusing. It is actually not strict because it supports all the cross-const comparison with iterator.
Outdated
...ange.take/range.take.sentinel/eq.pass.cpp
Resolved conversations (0)