Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AArch64][SME] Warn when using a streaming builtin from a non-streaming function #75487

Merged
merged 5 commits into from
Dec 18, 2023
Merged

[AArch64][SME] Warn when using a streaming builtin from a non-streaming function #75487

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9a8da1
[AArch64][SME] Warn when using a streaming builtin from a non-streami…
SamTebbs33 Nov 30, 2023
6dc8fa2
fixup: reduce compile time
SamTebbs33 Dec 14, 2023
711f1af
fixup: remove default
SamTebbs33 Dec 14, 2023
8c47b5f
fixup: remove sorting and emitted set
SamTebbs33 Dec 15, 2023
99b2d00
fixup: make builtintype optional for SME
SamTebbs33 Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: reduce compile time
  • Loading branch information
@SamTebbs33
SamTebbs33 committed Dec 14, 2023
commit 6dc8fa2c89159d234d9477358dd1ce1cbf059865
5 changes: 0 additions & 5 deletions clang/lib/Sema/SemaChecking.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3179,9 +3179,6 @@ bool Sema::CheckSMEBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
ArmStreamingType BuiltinType;

switch (BuiltinID) {
default:
BuiltinType = ArmNonStreaming;
break;
#define GET_SME_STREAMING_ATTRS
#include "clang/Basic/arm_sme_streaming_attrs.inc"
#undef GET_SME_STREAMING_ATTRS
Expand Down Expand Up @@ -3210,8 +3207,6 @@ bool Sema::CheckSVEBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
std::optional<ArmStreamingType> BuiltinType;

switch (BuiltinID) {
default:
break;
#define GET_SVE_STREAMING_ATTRS
#include "clang/Basic/arm_sve_streaming_attrs.inc"
#undef GET_SVE_STREAMING_ATTRS
Expand Down
39 changes: 29 additions & 10 deletions clang/utils/TableGen/SveEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1731,29 +1731,48 @@ void SVEEmitter::createStreamingAttrs(raw_ostream &OS, ACLEKind Kind) {

// Ensure these are only emitted once.
std::set<std::string> Emitted;
llvm::StringMap<std::set<std::string>> StreamingMap;
SamTebbs33 marked this conversation as resolved.
Show resolved Hide resolved

uint64_t IsStreamingFlag = getEnumValueForFlag("IsStreaming");
uint64_t IsStreamingCompatibleFlag =
getEnumValueForFlag("IsStreamingCompatible");
for (auto &Def : Defs) {
if (Emitted.find(Def->getMangledName()) != Emitted.end())
continue;

OS << "case " << ExtensionKind << "::BI__builtin_" << ExtensionKind.lower()
<< "_";
OS << Def->getMangledName() << ":\n";

if (Def->isFlagSet(IsStreamingFlag))
OS << " BuiltinType = ArmStreaming;\n";
StreamingMap["ArmStreaming"].insert(Def->getMangledName());
else if (Def->isFlagSet(IsStreamingCompatibleFlag))
OS << " BuiltinType = ArmStreamingCompatible;\n";
StreamingMap["ArmStreamingCompatible"].insert(Def->getMangledName());
else
OS << " BuiltinType = ArmNonStreaming;\n";
OS << " break;\n";

StreamingMap["ArmNonStreaming"].insert(Def->getMangledName());
Emitted.insert(Def->getMangledName());
}

for (auto BuiltinType : StreamingMap.keys()) {
// We can ignore ArmStreamingCompatible for SVE and ArmNonStreaming for SME
// as those are the defaults.
if (BuiltinType == "ArmNonStreaming" && ExtensionKind == "SME")
continue;
if (BuiltinType == "ArmStreamingCompatible" && ExtensionKind == "SVE")
continue;
for (auto Name : StreamingMap[BuiltinType]) {
OS << "case " << ExtensionKind << "::BI__builtin_"
<< ExtensionKind.lower() << "_";
OS << Name << ":\n";
}
OS << " BuiltinType = " << BuiltinType << ";\n";
OS << " break;\n";
}
if (ExtensionKind == "SME") {
OS << "default:\n";
OS << " BuiltinType = ArmNonStreaming;\n";
OS << " break;\n";
} else if (ExtensionKind == "SVE") {
OS << "default:\n";
OS << " BuiltinType = ArmStreamingCompatible;\n";
OS << " break;\n";
}

OS << "#endif\n\n";
}

Expand Down
Loading