diff --git a/libc/src/__support/FPUtil/FPBits.h b/libc/src/__support/FPUtil/FPBits.h index 7f5dd0fca58d4..594240de543ee 100644 --- a/libc/src/__support/FPUtil/FPBits.h +++ b/libc/src/__support/FPUtil/FPBits.h @@ -33,7 +33,11 @@ template struct FPBits : private FloatProperties { "FPBits instantiated with invalid type."); using typename FloatProperties::StorageType; using FloatProperties::TOTAL_LEN; - using FloatProperties::EXP_MANT_MASK; + +private: + using FloatProperties::EXP_SIG_MASK; + +public: using FloatProperties::EXP_MASK; using FloatProperties::EXP_BIAS; using FloatProperties::EXP_LEN; @@ -146,21 +150,25 @@ template struct FPBits : private FloatProperties { } LIBC_INLINE constexpr bool is_inf() const { - return (bits & EXP_MANT_MASK) == EXP_MASK; + return (bits & EXP_SIG_MASK) == EXP_MASK; } LIBC_INLINE constexpr bool is_nan() const { - return (bits & EXP_MANT_MASK) > EXP_MASK; + return (bits & EXP_SIG_MASK) > EXP_MASK; } LIBC_INLINE constexpr bool is_quiet_nan() const { - return (bits & EXP_MANT_MASK) == (EXP_MASK | QUIET_NAN_MASK); + return (bits & EXP_SIG_MASK) == (EXP_MASK | QUIET_NAN_MASK); } LIBC_INLINE constexpr bool is_inf_or_nan() const { return (bits & EXP_MASK) == EXP_MASK; } + LIBC_INLINE constexpr FPBits abs() const { + return FPBits(bits & EXP_SIG_MASK); + } + LIBC_INLINE static constexpr T zero(bool sign = false) { return FPBits(sign ? SIGN_MASK : StorageType(0)).get_val(); } diff --git a/libc/src/__support/FPUtil/FloatProperties.h b/libc/src/__support/FPUtil/FloatProperties.h index 896c29919e2f7..438dbaa2d3fec 100644 --- a/libc/src/__support/FPUtil/FloatProperties.h +++ b/libc/src/__support/FPUtil/FloatProperties.h @@ -131,6 +131,9 @@ struct FPProperties : public internal::FPBaseProperties { // The bit pattern that keeps only the *sign* part. LIBC_INLINE_VAR static constexpr StorageType SIGN_MASK = mask_trailing_ones() << SIGN_MASK_SHIFT; + // The bit pattern that keeps only the *exponent + significand* part. + LIBC_INLINE_VAR static constexpr StorageType EXP_SIG_MASK = + mask_trailing_ones(); // The bit pattern that keeps only the *sign + exponent + significand* part. LIBC_INLINE_VAR static constexpr StorageType FP_MASK = mask_trailing_ones(); @@ -162,8 +165,6 @@ struct FPProperties : public internal::FPBaseProperties { FRACTION_LEN + 1; LIBC_INLINE_VAR static constexpr StorageType FRACTION_MASK = mask_trailing_ones(); - LIBC_INLINE_VAR static constexpr StorageType EXP_MANT_MASK = - EXP_MASK | SIG_MASK; // If a number x is a NAN, then it is a quiet NAN if: // QuietNaNMask & bits(x) != 0 diff --git a/libc/src/__support/FPUtil/x86_64/LongDoubleBits.h b/libc/src/__support/FPUtil/x86_64/LongDoubleBits.h index 89c47063ebac4..b6054b4d61e93 100644 --- a/libc/src/__support/FPUtil/x86_64/LongDoubleBits.h +++ b/libc/src/__support/FPUtil/x86_64/LongDoubleBits.h @@ -29,7 +29,6 @@ namespace fputil { template <> struct FPBits : private FloatProperties { using typename FloatProperties::StorageType; using FloatProperties::TOTAL_LEN; - using FloatProperties::EXP_MANT_MASK; using FloatProperties::EXP_MASK; using FloatProperties::EXP_BIAS; using FloatProperties::EXP_LEN; diff --git a/libc/src/math/generic/acoshf.cpp b/libc/src/math/generic/acoshf.cpp index 142c17795d083..b0b87095fbb07 100644 --- a/libc/src/math/generic/acoshf.cpp +++ b/libc/src/math/generic/acoshf.cpp @@ -34,7 +34,7 @@ LLVM_LIBC_FUNCTION(float, acoshf, (float x)) { if (LIBC_UNLIKELY(x_u >= 0x4f8ffb03)) { // Check for exceptional values. - uint32_t x_abs = x_u & FPBits_t::EXP_MANT_MASK; + uint32_t x_abs = xbits.abs().uintval(); if (LIBC_UNLIKELY(x_abs >= 0x7f80'0000U)) { // x is +inf or NaN. return x; diff --git a/libc/src/math/generic/asinhf.cpp b/libc/src/math/generic/asinhf.cpp index 5b2f63d3fe144..ac059910b4ef2 100644 --- a/libc/src/math/generic/asinhf.cpp +++ b/libc/src/math/generic/asinhf.cpp @@ -21,7 +21,7 @@ LLVM_LIBC_FUNCTION(float, asinhf, (float x)) { using FPBits_t = typename fputil::FPBits; FPBits_t xbits(x); uint32_t x_u = xbits.uintval(); - uint32_t x_abs = x_u & FPBits_t::EXP_MANT_MASK; + uint32_t x_abs = xbits.abs().uintval(); // |x| <= 2^-3 if (LIBC_UNLIKELY(x_abs <= 0x3e80'0000U)) { diff --git a/libc/src/math/generic/atanhf.cpp b/libc/src/math/generic/atanhf.cpp index dfec28e9a44a7..df5f53f392cf3 100644 --- a/libc/src/math/generic/atanhf.cpp +++ b/libc/src/math/generic/atanhf.cpp @@ -17,7 +17,7 @@ LLVM_LIBC_FUNCTION(float, atanhf, (float x)) { using FPBits = typename fputil::FPBits; FPBits xbits(x); bool sign = xbits.get_sign(); - uint32_t x_abs = xbits.uintval() & FPBits::EXP_MANT_MASK; + uint32_t x_abs = xbits.abs().uintval(); // |x| >= 1.0 if (LIBC_UNLIKELY(x_abs >= 0x3F80'0000U)) { diff --git a/libc/src/math/generic/exp.cpp b/libc/src/math/generic/exp.cpp index ebfd14dd6cc16..35f5e62a7d1ea 100644 --- a/libc/src/math/generic/exp.cpp +++ b/libc/src/math/generic/exp.cpp @@ -174,11 +174,10 @@ DoubleDouble exp_double_double(double x, double kd, // |x| <= 2^-53 or x < log(2^-1075) or x >= 0x1.6232bdd7abcd3p+9 double set_exceptional(double x) { using FPBits = typename fputil::FPBits; - using FloatProp = typename fputil::FloatProperties; FPBits xbits(x); uint64_t x_u = xbits.uintval(); - uint64_t x_abs = x_u & FloatProp::EXP_MANT_MASK; + uint64_t x_abs = xbits.abs().uintval(); // |x| <= 2^-53 if (x_abs <= 0x3ca0'0000'0000'0000ULL) { diff --git a/libc/src/math/generic/exp10.cpp b/libc/src/math/generic/exp10.cpp index 4e1babcee541b..050a86e70a798 100644 --- a/libc/src/math/generic/exp10.cpp +++ b/libc/src/math/generic/exp10.cpp @@ -221,11 +221,10 @@ double exp10_denorm(double x) { // * x is inf or nan double set_exceptional(double x) { using FPBits = typename fputil::FPBits; - using FloatProp = typename fputil::FloatProperties; FPBits xbits(x); uint64_t x_u = xbits.uintval(); - uint64_t x_abs = x_u & FloatProp::EXP_MANT_MASK; + uint64_t x_abs = xbits.abs().uintval(); // |x| < log10(1 + 2^-53) if (x_abs <= 0x3c8bcb7b1526e50e) { diff --git a/libc/src/math/generic/exp2.cpp b/libc/src/math/generic/exp2.cpp index 07691ca0e7b62..3a012db76ec41 100644 --- a/libc/src/math/generic/exp2.cpp +++ b/libc/src/math/generic/exp2.cpp @@ -196,11 +196,10 @@ double exp2_denorm(double x) { // * x is inf or nan double set_exceptional(double x) { using FPBits = typename fputil::FPBits; - using FloatProp = typename fputil::FloatProperties; FPBits xbits(x); uint64_t x_u = xbits.uintval(); - uint64_t x_abs = x_u & FloatProp::EXP_MANT_MASK; + uint64_t x_abs = xbits.abs().uintval(); // |x| < log2(1 + 2^-53) if (x_abs <= 0x3ca71547652b82fd) { diff --git a/libc/src/math/generic/expm1.cpp b/libc/src/math/generic/expm1.cpp index a0d47f00828ce..f26c5cfb6e0f2 100644 --- a/libc/src/math/generic/expm1.cpp +++ b/libc/src/math/generic/expm1.cpp @@ -219,11 +219,10 @@ DoubleDouble exp_double_double(double x, double kd, const DoubleDouble &exp_mid, // |x| <= 2^-53 or x < log(2^-54) or x >= 0x1.6232bdd7abcd3p+9 double set_exceptional(double x) { using FPBits = typename fputil::FPBits; - using FloatProp = typename fputil::FloatProperties; FPBits xbits(x); uint64_t x_u = xbits.uintval(); - uint64_t x_abs = x_u & FloatProp::EXP_MANT_MASK; + uint64_t x_abs = xbits.abs().uintval(); // |x| <= 2^-53. if (x_abs <= 0x3ca0'0000'0000'0000ULL) { diff --git a/libc/src/math/generic/inv_trigf_utils.h b/libc/src/math/generic/inv_trigf_utils.h index 588ebbfa71aeb..4e85d4ae08d57 100644 --- a/libc/src/math/generic/inv_trigf_utils.h +++ b/libc/src/math/generic/inv_trigf_utils.h @@ -50,7 +50,7 @@ LIBC_INLINE double atan_eval(double x) { FPB bs(x); bool sign = bs.get_sign(); - auto x_abs = bs.uintval() & FPB::EXP_MANT_MASK; + auto x_abs = bs.abs().uintval(); if (x_abs <= umin) { double pe = LIBC_NAMESPACE::fputil::polyeval( diff --git a/libc/src/math/generic/powf.cpp b/libc/src/math/generic/powf.cpp index dd7fa7f6115d4..8470eb878e603 100644 --- a/libc/src/math/generic/powf.cpp +++ b/libc/src/math/generic/powf.cpp @@ -517,9 +517,9 @@ LLVM_LIBC_FUNCTION(float, powf, (float x, float y)) { FloatBits xbits(x), ybits(y); uint32_t x_u = xbits.uintval(); - uint32_t x_abs = x_u & FloatProp::EXP_MANT_MASK; + uint32_t x_abs = xbits.abs().uintval(); uint32_t y_u = ybits.uintval(); - uint32_t y_abs = y_u & FloatProp::EXP_MANT_MASK; + uint32_t y_abs = ybits.abs().uintval(); ///////// BEGIN - Check exceptional cases //////////////////////////////////// diff --git a/libc/src/math/generic/sinhf.cpp b/libc/src/math/generic/sinhf.cpp index db6794620b068..303ac8b72f591 100644 --- a/libc/src/math/generic/sinhf.cpp +++ b/libc/src/math/generic/sinhf.cpp @@ -17,7 +17,7 @@ namespace LIBC_NAMESPACE { LLVM_LIBC_FUNCTION(float, sinhf, (float x)) { using FPBits = typename fputil::FPBits; FPBits xbits(x); - uint32_t x_abs = xbits.uintval() & FPBits::EXP_MANT_MASK; + uint32_t x_abs = xbits.abs().uintval(); // When |x| >= 90, or x is inf or nan if (LIBC_UNLIKELY(x_abs >= 0x42b4'0000U || x_abs <= 0x3da0'0000U)) { diff --git a/libc/src/math/generic/tanhf.cpp b/libc/src/math/generic/tanhf.cpp index 9042a41c5ed3f..073097e1208af 100644 --- a/libc/src/math/generic/tanhf.cpp +++ b/libc/src/math/generic/tanhf.cpp @@ -23,8 +23,7 @@ constexpr double LOG2_E_EXP2_6 = ExpBase::LOG2_B * 2.0; LLVM_LIBC_FUNCTION(float, tanhf, (float x)) { using FPBits = typename fputil::FPBits; FPBits xbits(x); - uint32_t x_u = xbits.uintval(); - uint32_t x_abs = x_u & FPBits::EXP_MANT_MASK; + uint32_t x_abs = xbits.abs().uintval(); // When |x| >= 15, or x is inf or nan, or |x| <= 0.078125 if (LIBC_UNLIKELY((x_abs >= 0x4170'0000U) || (x_abs <= 0x3da0'0000U))) {