Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (3)
@joker-eph joker-eph Jan 2, 2024
```suggestion SmallVectorImpl<Value> &loadIndices, ```
Outdated
...ib/Conversion/VectorToSCF/VectorToSCF.cpp
@joker-eph joker-eph Jan 2, 2024
```suggestion for (Operation *user : maskBuffer.getUsers()) { // If there is no previous load op, then the indices are empty. if (auto loadOp = dyn_cast<memref::LoadOp>(user)) { ```
Outdated
...ib/Conversion/VectorToSCF/VectorToSCF.cpp
@joker-eph joker-eph Jan 2, 2024
Why are you introducing a `dyn_cast` here?
Outdated
...ib/Conversion/VectorToSCF/VectorToSCF.cpp
rikhuijzer joker-eph