[OMPD] Runtime Entry Point functions for OMPD in libomp.so need C linkage as per standard. #79246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The header file published by the OpenMP LC just has one big extern "C" scope: https://github.com/OpenMP/sources/blob/main/include/omp-tools.h Is there any good reason, to not follow this approach? |
Encapsulating required OMPD and OMPT data structures and signatures within extern "C" as per the supplementary soure file for omp-tools.h provided by the OpenMP spec https://github.com/OpenMP/sources/blob/main/include/omp-tools.h, thus ensuring that the OMPD runtime entry point functions have C linkage and are not mangled.
vigbalu
force-pushed
the
OMPD_demangle_runtime_entry_fns
branch
from
ae2c66c
to
9c3eb85
Compare
|
Joachim, have modified as per supplement provided by standard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding extern "C" to all the entry point functions to make sure that these functions are not mangled.