[Libomptarget] Remove remaining inline assembly from the device RTL #79922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Recent patches have added some missing intrinsic functions NVPTX. This patch gets rid of all the remaining uses of inline assembly. The one change that wasn't directly replaced with a built-in was the `pack` and `unpack` implementations. However, using the generic C implementation is equivalent to the output SASS when run through PTXAS.
jhuber6
requested review from
dhruvachak,
jdoerfert,
JonChesterfield,
jplehr,
ronlieb,
saiislam and
shiltian
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Recent patches have added some missing intrinsic functions NVPTX. This
patch gets rid of all the remaining uses of inline assembly. The one
change that wasn't directly replaced with a built-in was the
packandunpackimplementations. However, using the generic C implementation isequivalent to the output SASS when run through PTXAS.