[clangd] SelectionTree marks nodes as complete only if children are complete #82237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omplete This seems to be the semantics expected by ~all callers, and simplifies upcoming patches extending extract-variable.
|
@llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clangd Author: Sam McCall (sam-mccall) ChangesThis seems to be the semantics expected by ~all callers, and simplifies Full diff: https://github.com/llvm/llvm-project/pull/82237.diff 1 Files Affected:
diff --git a/clang-tools-extra/clangd/unittests/SelectionTests.cpp b/clang-tools-extra/clangd/unittests/SelectionTests.cpp
index 754e8c287c5148..162428f8169158 100644
--- a/clang-tools-extra/clangd/unittests/SelectionTests.cpp
+++ b/clang-tools-extra/clangd/unittests/SelectionTests.cpp
@@ -688,6 +688,7 @@ TEST(SelectionTest, Selected) {
)cpp",
R"cpp( $C[[^$C[[int]] a^]]; )cpp",
R"cpp( $C[[^$C[[int]] a = $C[[5]]^]]; )cpp",
+ R"cpp( int x = [[2 ^+ $C[[2]]^]]; )cpp",
};
for (const char *C : Cases) {
Annotations Test(C);
|
kadircet
requested changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be the semantics expected by ~all callers, and simplifies
upcoming patches extending extract-variable.