[llvm] Remove pipeline checks for optsize for DFAJumpThreadingPass #83188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
aeubanks
approved these changes
Feb 27, 2024
ilovepi
merged commit 395d0b8
into
users/ilovepi/spr/main.llvm-remove-pipeline-checks-for-optsize-for-dfajumpthreadingpass
3 of 4 checks passed
ilovepi
deleted the
users/ilovepi/spr/llvm-remove-pipeline-checks-for-optsize-for-dfajumpthreadingpass
branch
|
huh, not sure why spr merged this into a branch, but I'll need to fix that. |
ilovepi
restored the
users/ilovepi/spr/llvm-remove-pipeline-checks-for-optsize-for-dfajumpthreadingpass
branch
ilovepi
deleted the
users/ilovepi/spr/llvm-remove-pipeline-checks-for-optsize-for-dfajumpthreadingpass
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pass itself checks whether to apply the optimization based on the
minsize attribute, so there isn't much functional benefit to preventing
the pass from being added. Gating the pass gets added to the pass
pipeline complicates the interaction with -enable-dfa-jump-thread, as
well.