diff --git a/clang/include/clang/Basic/TargetInfo.h b/clang/include/clang/Basic/TargetInfo.h index 7682f84e491c7..9eeeecd68147f 100644 --- a/clang/include/clang/Basic/TargetInfo.h +++ b/clang/include/clang/Basic/TargetInfo.h @@ -31,7 +31,9 @@ #include "llvm/ADT/StringRef.h" #include "llvm/ADT/StringSet.h" #include "llvm/Frontend/OpenMP/OMPGridValues.h" +#include "llvm/IR/Attributes.h" #include "llvm/IR/DerivedTypes.h" +#include "llvm/IR/Function.h" #include "llvm/Support/DataTypes.h" #include "llvm/Support/Error.h" #include "llvm/Support/VersionTuple.h" @@ -1368,15 +1370,14 @@ class TargetInfo : public TransferrableTargetInfo, return StringRef(); } - struct BranchProtectionInfo { + class BranchProtectionInfo { + public: LangOptions::SignReturnAddressScopeKind SignReturnAddr; LangOptions::SignReturnAddressKeyKind SignKey; bool BranchTargetEnforcement; bool BranchProtectionPAuthLR; bool GuardedControlStack; - BranchProtectionInfo() = default; - const char *getSignReturnAddrStr() const { switch (SignReturnAddr) { case LangOptions::SignReturnAddressScopeKind::None: @@ -1388,7 +1389,6 @@ class TargetInfo : public TransferrableTargetInfo, } llvm_unreachable("Unexpected SignReturnAddressScopeKind"); } - const char *getSignKeyStr() const { switch (SignKey) { case LangOptions::SignReturnAddressKeyKind::AKey: @@ -1398,6 +1398,41 @@ class TargetInfo : public TransferrableTargetInfo, } llvm_unreachable("Unexpected SignReturnAddressKeyKind"); } + + BranchProtectionInfo() = default; + BranchProtectionInfo(const LangOptions &LangOpts) { + SignReturnAddr = + LangOpts.hasSignReturnAddress() + ? (LangOpts.isSignReturnAddressScopeAll() + ? LangOptions::SignReturnAddressScopeKind::All + : LangOptions::SignReturnAddressScopeKind::NonLeaf) + : LangOptions::SignReturnAddressScopeKind::None; + SignKey = LangOpts.isSignReturnAddressWithAKey() + ? LangOptions::SignReturnAddressKeyKind::AKey + : LangOptions::SignReturnAddressKeyKind::BKey; + BranchTargetEnforcement = LangOpts.BranchTargetEnforcement; + BranchProtectionPAuthLR = LangOpts.BranchProtectionPAuthLR; + GuardedControlStack = LangOpts.GuardedControlStack; + } + + void setFnAttributes(llvm::Function &F) { + llvm::AttrBuilder FuncAttrs(F.getContext()); + setFnAttributes(FuncAttrs); + F.addFnAttrs(FuncAttrs); + } + + void setFnAttributes(llvm::AttrBuilder &FuncAttrs) { + if (SignReturnAddr != LangOptions::SignReturnAddressScopeKind::None) { + FuncAttrs.addAttribute("sign-return-address", getSignReturnAddrStr()); + FuncAttrs.addAttribute("sign-return-address-key", getSignKeyStr()); + } + if (BranchTargetEnforcement) + FuncAttrs.addAttribute("branch-target-enforcement", "true"); + if (BranchProtectionPAuthLR) + FuncAttrs.addAttribute("branch-protection-pauth-lr", "true"); + if (GuardedControlStack) + FuncAttrs.addAttribute("guarded-control-stack", "true"); + } }; /// Determine if the Architecture in this TargetInfo supports branch diff --git a/clang/lib/CodeGen/CGCall.cpp b/clang/lib/CodeGen/CGCall.cpp index 13f68237b464d..8f13b84908805 100644 --- a/clang/lib/CodeGen/CGCall.cpp +++ b/clang/lib/CodeGen/CGCall.cpp @@ -2022,6 +2022,9 @@ static void getTrivialDefaultFunctionAttributes( std::tie(Var, Value) = Attr.split('='); FuncAttrs.addAttribute(Var, Value); } + + TargetInfo::BranchProtectionInfo BPI(LangOpts); + BPI.setFnAttributes(FuncAttrs); } /// Merges `target-features` from \TargetOpts and \F, and sets the result in diff --git a/clang/test/CodeGenCXX/arm64-generated-fn-attr.cpp b/clang/test/CodeGenCXX/arm64-generated-fn-attr.cpp new file mode 100644 index 0000000000000..de35c32e9c18a --- /dev/null +++ b/clang/test/CodeGenCXX/arm64-generated-fn-attr.cpp @@ -0,0 +1,30 @@ +// RUN: %clang_cc1 -triple aarch64 -mbranch-target-enforce -msign-return-address=all -fcxx-exceptions -fexceptions -emit-llvm %s -o - | FileCheck %s + +// Check that functions generated by clang have the correct attributes + +class Example { +public: + Example(); + int fn(); +}; + +// Initialization of var1 causes __cxx_global_var_init and __tls_init to be generated +thread_local Example var1; +extern thread_local Example var2; +extern void fn(); + +int testfn() noexcept { + // Calling fn in a noexcept function causes __clang_call_terminate to be generated + fn(); + // Use of var1 and var2 causes TLS wrapper functions to be generated + return var1.fn() + var2.fn(); +} + +// CHECK: define {{.*}} @__cxx_global_var_init() [[ATTR1:#[0-9]+]] +// CHECK: define {{.*}} @__clang_call_terminate({{.*}}) [[ATTR2:#[0-9]+]] +// CHECK: define {{.*}} @_ZTW4var1() [[ATTR1]] +// CHECK: define {{.*}} @_ZTW4var2() [[ATTR1]] +// CHECK: define {{.*}} @__tls_init() [[ATTR1]] + +// CHECK: attributes [[ATTR1]] = { {{.*}}"branch-target-enforcement"="true"{{.*}}"sign-return-address"="all" "sign-return-address-key"="a_key" +// CHECK: attributes [[ATTR2]] = { {{.*}}"branch-target-enforcement"="true"{{.*}}"sign-return-address"="all" "sign-return-address-key"="a_key"