From 5d803dc44a090787bdf21432b2f91aa98e66d35b Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Sat, 2 Mar 2024 14:15:18 -0800 Subject: [PATCH 1/2] workflows: Fixes for building the release binaries Since aa02002491333c42060373bc84f1ff5d2c76b4ce we weren't installing the correct dependencies, and since 2836d8edbfbcd461b25101ed58f93c862d65903a we must pass a custom token to github-upload-release.py for verifying permissions. --- .github/workflows/release-binaries.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml index ebf6fa41898dc..eb3a4f0fc9462 100644 --- a/.github/workflows/release-binaries.yml +++ b/.github/workflows/release-binaries.yml @@ -44,14 +44,21 @@ jobs: upload: ${{ steps.vars.outputs.upload }} steps: + - name: Install Dependencies + run: | + sudo apt-get update + sudo apt-get install -y \ + python3-github + - name: Checkout LLVM uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 - name: Check Permissions env: GITHUB_TOKEN: ${{ github.token }} + USER_TOKEN: ${{ secrets.RELEASE_TASKS_USER_TOKEN }} run: | - ./llvm/utils/release/./github-upload-release.py --token "$GITHUB_TOKEN" --user ${{ github.actor }} check-permissions + ./llvm/utils/release/./github-upload-release.py --token "$GITHUB_TOKEN" --user ${{ github.actor }} --user-token "$USER_TOKEN" check-permissions - name: Collect Variables id: vars From 203309a7856b540d326beded294fd22ec4e6858d Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Fri, 8 Mar 2024 05:33:49 +0000 Subject: [PATCH 2/2] Use requirements.txt for dependencies --- .github/workflows/release-binaries.yml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml index eb3a4f0fc9462..282ace2a48bdc 100644 --- a/.github/workflows/release-binaries.yml +++ b/.github/workflows/release-binaries.yml @@ -44,15 +44,13 @@ jobs: upload: ${{ steps.vars.outputs.upload }} steps: - - name: Install Dependencies - run: | - sudo apt-get update - sudo apt-get install -y \ - python3-github - - name: Checkout LLVM uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - name: Install Dependencies + run: | + pip install -r ./llvm/utils/git/requirements.txt + - name: Check Permissions env: GITHUB_TOKEN: ${{ github.token }}