Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OMPT] Fix issue #84180 #84215

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

rpereira-dev
Copy link

Option (2) suggested to fix #84180

Copy link

github-actions bot commented Mar 6, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@jprotze
Copy link
Collaborator

jprotze commented Mar 27, 2024

Please extend test/ompt/cancel/cancel_taskgroup.c by checks that the extra switches are not there.

@rpereira-dev
Copy link
Author

rpereira-dev commented Mar 28, 2024

I started just that @jprotze and then realized we could generalize tests to task_schedule callbacks, not only cancellation.

What about tracking tasks bound on threads in the callback.h tool and ensuring coherency with the prior_task_data passed by the runtime ?
I have done just that but it implied sed-ing most test files which assumed thread_data->value is a thread id, and is now a couple (thread_id, current_task_id).

I added #84180 minimal example to test/ompt/cancel/cancel_taskgroup.c and a CHECK-NOT 0: wrong task_schedule

Good thing is grepping 0: wrong task_schedule in test outputs detects other issues in:

  • ompt/tasks/task_types_serialized.c - that is [OMPT] Untied tasks schedules #83883
  • ompt/parallel/region_in_expl_task_task_frames.c - yet another issue related to task_schedule callbacks

I have not added a check in these 2 tests as this PR does not fix them

Let me know if thats too much modifications, I can still revert and check only the test/ompt/cancel/cancel_taskgroup.c without modifying the rest of the world

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomp OpenMP host runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OMPT] Cancelled tasks schedules
3 participants