-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OMPT] Fix issue #84180 #84215
base: main
Are you sure you want to change the base?
[OMPT] Fix issue #84180 #84215
Conversation
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
Please extend test/ompt/cancel/cancel_taskgroup.c by checks that the extra switches are not there. |
I started just that @jprotze and then realized we could generalize tests to What about tracking tasks bound on threads in the I added #84180 minimal example to Good thing is grepping
I have not added a check in these 2 tests as this PR does not fix them Let me know if thats too much modifications, I can still revert and check only the |
Option (2) suggested to fix #84180