[OpenMP] Disable flaky barrier fence test #85093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This test is flaky on all targets I know of. We should disable it for now so running the test suite doesn't randomly fail 50% of the time.
|
Can you also open a ticket in case we lose the track? |
saiislam
approved these changes
Mar 13, 2024
|
This can't be the way we do development and I'll bring this up in the meeting. |
jhuber6
added a commit
that referenced
this pull request
Mar 19, 2024
This reverts commit cd8843f. Originally disabled to try to unstick the AMD build bot, didn't make a difference after a week so it goes back in.
chencha3
pushed a commit
to chencha3/llvm-project
that referenced
this pull request
Mar 23, 2024
This reverts commit cd8843f. Originally disabled to try to unstick the AMD build bot, didn't make a difference after a week so it goes back in.
|
Is the issue up? |
It was reverted so the test is active now, but no one has made an issue about it being flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This test is flaky on all targets I know of. We should disable it for
now so running the test suite doesn't randomly fail 50% of the time.