diff --git a/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp index dd204b62dcc04..6c18f2a1d9ee4 100644 --- a/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp @@ -1096,12 +1096,15 @@ static bool isStandardNewDelete(const FunctionDecl *FD) { Kind != OO_Array_Delete) return false; + bool HasBody = FD->hasBody(); // Prefer using the definition. + // This is standard if and only if it's not defined in a user file. SourceLocation L = FD->getLocation(); + // If the header for operator delete is not included, it's still defined // in an invalid source location. Check to make sure we don't crash. - return !L.isValid() || - FD->getASTContext().getSourceManager().isInSystemHeader(L); + const auto &SM = FD->getASTContext().getSourceManager(); + return L.isInvalid() || (!HasBody && SM.isInSystemHeader(L)); } //===----------------------------------------------------------------------===// diff --git a/clang/test/Analysis/Inputs/overloaded-delete-in-header.h b/clang/test/Analysis/Inputs/overloaded-delete-in-header.h new file mode 100644 index 0000000000000..8243961d84830 --- /dev/null +++ b/clang/test/Analysis/Inputs/overloaded-delete-in-header.h @@ -0,0 +1,18 @@ +#ifndef OVERLOADED_DELETE_IN_HEADER +#define OVERLOADED_DELETE_IN_HEADER + +struct DeleteInHeader { + int data; + static void operator delete(void *ptr); +}; + +void DeleteInHeader::operator delete(void *ptr) { + DeleteInHeader *self = (DeleteInHeader *)ptr; + self->data = 1; // no-warning: Still alive. + + ::operator delete(ptr); + + self->data = 2; // expected-warning {{Use of memory after it is freed [cplusplus.NewDelete]}} +} + +#endif // OVERLOADED_DELETE_IN_SYSTEM_HEADER diff --git a/clang/test/Analysis/overloaded-delete-in-system-header.cpp b/clang/test/Analysis/overloaded-delete-in-system-header.cpp new file mode 100644 index 0000000000000..c284a94206306 --- /dev/null +++ b/clang/test/Analysis/overloaded-delete-in-system-header.cpp @@ -0,0 +1,9 @@ +// RUN: %clang_analyze_cc1 -isystem %S/Inputs/ -verify %s \ +// RUN: -analyzer-checker=core,unix.Malloc,cplusplus.NewDelete + +// RUN: %clang_analyze_cc1 -I %S/Inputs/ -verify %s \ +// RUN: -analyzer-checker=core,unix.Malloc,cplusplus.NewDelete + +#include "overloaded-delete-in-header.h" + +void deleteInHeader(DeleteInHeader *p) { delete p; }