Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (3)
@lntue lntue Mar 15, 2024
Use `DECLARE_SPECIAL_CONSTANTS` macro here.
Outdated
libc/test/src/math/smoke/NextUpTest.h
@lntue lntue Mar 15, 2024
You can add the signed versions to `DECLARE_SPECIAL_CONSTANTS` macro and use it here: https://github.com/llvm/llvm-project/blob/main/libc/test/UnitTest/FPMatcher.h#L92
Outdated
libc/test/src/math/smoke/NextDownTest.h
lntue overmighty
@lntue lntue Mar 15, 2024
Use the second template parameter for the `sign`, and use `enable_if_t` on the return type instead. Also mark this function `constexpr` if possible.
Outdated
.../__support/FPUtil/ManipulationFunctions.h
overmighty