Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BOLT] Use BAT to register fragments #87968

Closed
wants to merge 1 commit into from
Closed

[BOLT] Use BAT to register fragments #87968

wants to merge 1 commit into from

Conversation

aaupov
Copy link
Contributor

@aaupov aaupov commented Apr 8, 2024

BAT contains metadata about fragment relationships. Use it directly
before name-based matching. This removes warnings about control flow
between unrelated fragments.

Test Plan: TBD

@aaupov
[𝘀𝗽𝗿] initial version
57eea10 
Created using spr 1.3.4
maksfb
maksfb reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@maksfb maksfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is information we emit in the symbol table insufficient to establish the fragment relationship?

@aaupov aaupov closed this Apr 15, 2024
@aaupov aaupov deleted the users/aaupov/spr/bolt-use-bat-to-register-fragments branch April 30, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maksfb maksfb maksfb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aaupov @maksfb