Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clang] Fix test broken due to unsupported calling convention #88472

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

Sirraide
Copy link
Contributor

#88428 ended up breaking CI because it included a test that uses the regcall calling convention, which isn’t supported on all targets; I’ve moved it into a separate file that sets the triple.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Apr 12, 2024
@Sirraide Sirraide merged commit b502dc5 into llvm:main Apr 12, 2024
5 of 6 checks passed
@Sirraide Sirraide deleted the dependent-captures-fix-2 branch April 12, 2024 05:13
@llvmbot
Copy link
Collaborator

llvmbot commented Apr 12, 2024

@llvm/pr-subscribers-clang

Author: None (Sirraide)

Changes

#88428 ended up breaking CI because it included a test that uses the regcall calling convention, which isn’t supported on all targets; I’ve moved it into a separate file that sets the triple.


Full diff: https://github.com/llvm/llvm-project/pull/88472.diff

2 Files Affected:

  • (added) clang/test/SemaCXX/gh84473.cpp (+11)
  • (modified) clang/test/SemaCXX/lambda-expressions.cpp (-9)
diff --git a/clang/test/SemaCXX/gh84473.cpp b/clang/test/SemaCXX/gh84473.cpp
new file mode 100644
index 00000000000000..72f5e9c45b0c48
--- /dev/null
+++ b/clang/test/SemaCXX/gh84473.cpp
@@ -0,0 +1,11 @@
+// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -std=c++23 -fsyntax-only -verify %s
+// expected-no-diagnostics
+
+namespace GH84473_bug {
+void f1() {
+  int b;
+  (void) [=] [[gnu::regcall]] () {
+    (void) b;
+  };
+}
+}
diff --git a/clang/test/SemaCXX/lambda-expressions.cpp b/clang/test/SemaCXX/lambda-expressions.cpp
index 6be338064452ed..151d74f21d64dc 100644
--- a/clang/test/SemaCXX/lambda-expressions.cpp
+++ b/clang/test/SemaCXX/lambda-expressions.cpp
@@ -762,12 +762,3 @@ template auto t::operator()<int>(int a) const; // expected-note {{in instantiati
 
 }
 #endif
-
-namespace GH84473_bug {
-void f1() {
-  int b;
-  (void) [=] [[gnu::regcall]] () { // expected-warning {{an attribute specifier sequence in this position is a C++23 extension}}
-    (void) b;
-  };
-}
-}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants