Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/18.x: [RISCV] Support rv{32, 64}e in the compiler builtins (#88252) #88525

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Apr 12, 2024

Backport bd32aaa

Requested by: @wangpc-pp

@llvmbot llvmbot added this to the LLVM 18.X Release milestone Apr 12, 2024
@llvmbot
Copy link
Collaborator Author

llvmbot commented Apr 12, 2024

@kito-cheng What do you think about merging this PR to the release branch?

@xermicus
Copy link
Contributor

compiler-rt doesn't build for RISC-V embedded targets without this patch so to me it'd make sense to backport :)

Copy link
Member

@kito-cheng kito-cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Register spills (save/restore) in RISC-V embedded work differently
because there are less registers and different stack alignment.

[GCC equivalent
](https://github.com/gcc-mirror/gcc/blob/master/libgcc/config/riscv/save-restore.S#L298C16-L336)

Follow up from llvm#76777.

---------

Signed-off-by: xermicus <cyrill@parity.io>
(cherry picked from commit bd32aaa)
@tstellar tstellar merged commit eaae766 into llvm:release/18.x Apr 15, 2024
3 of 4 checks passed
@tstellar
Copy link
Collaborator

Hi @wangpc-pp (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix.

@wangpc-pp
Copy link
Contributor

wangpc-pp commented Apr 16, 2024

Hi @wangpc-pp (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix.

Yeah, the description can be:

Save/restore routines for RV32E/RV64E are added to compiler-rt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants