Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb][NFC] Handle UnresolvedTemplate type in TypeSystemClang.cpp after 7a484d3 #91132

Closed
wants to merge 1 commit into from

Conversation

zyn0217
Copy link
Contributor

@zyn0217 zyn0217 commented May 5, 2024

The fix per se seems trivial (given the nature of the new built-in type), and hence I don't think we need extra tests.

@llvmbot
Copy link
Collaborator

llvmbot commented May 5, 2024

@llvm/pr-subscribers-lldb

Author: Younan Zhang (zyn0217)

Changes

The fix per se seems trivial (given the nature of the new built-in type), and hence I don't think we need extra tests.


Full diff: https://github.com/llvm/llvm-project/pull/91132.diff

1 Files Affected:

  • (modified) lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp (+2)
diff --git a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
index 2621f682011b41e..08d32e71c7fd32e 100644
--- a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
+++ b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
@@ -3983,6 +3983,7 @@ TypeSystemClang::GetMinimumLanguage(lldb::opaque_compiler_type_t type) {
 
       case clang::BuiltinType::Dependent:
       case clang::BuiltinType::Overload:
+      case clang::BuiltinType::UnresolvedTemplate:
       case clang::BuiltinType::BoundMember:
       case clang::BuiltinType::UnknownAny:
         break;
@@ -5962,6 +5963,7 @@ uint32_t TypeSystemClang::GetNumPointeeChildren(clang::QualType type) {
     case clang::BuiltinType::LongDouble:
     case clang::BuiltinType::Dependent:
     case clang::BuiltinType::Overload:
+    case clang::BuiltinType::UnresolvedTemplate:
     case clang::BuiltinType::ObjCId:
     case clang::BuiltinType::ObjCClass:
     case clang::BuiltinType::ObjCSel:

@zyn0217
Copy link
Contributor Author

zyn0217 commented May 5, 2024

@aganea Feel free to commit this PR yourself if this works - It's midnight and I'm not going to sit here. Thanks!

@zyn0217
Copy link
Contributor Author

zyn0217 commented May 6, 2024

This had been fixed by 41574f5. Thanks @dwblaikie!

@zyn0217 zyn0217 closed this May 6, 2024
@zyn0217 zyn0217 deleted the fixup-after-89019 branch May 6, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants