[lldb/crashlog] Update incorrect help message for --no-crashed-only option

[medismailben]

This patch rephrases the crashlog --no-crashed-only option help message. This option is mainly used in batch mode to symbolicate and dump all the threads backtraces, instead of only doing it for the crashed thread which is the default behavior.

rdar://127391524

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Med Ismail Bennani (medismailben)

Changes

This patch rephrases the crashlog --no-crashed-only option help message. This option is mainly used in batch mode to symbolicate and dump all the threads backtraces, instead of only doing it for the crashed thread which is the default behavior.

rdar://127391524

---

Full diff: https://github.com/llvm/llvm-project/pull/91162.diff

1 Files Affected:

• (modified) lldb/examples/python/crashlog.py (+2-1)

diff --git a/lldb/examples/python/crashlog.py b/lldb/examples/python/crashlog.py
index c992348b24be17..cdcf6ffc593daf 100755
--- a/lldb/examples/python/crashlog.py
+++ b/lldb/examples/python/crashlog.py
@@ -1631,7 +1631,8 @@ def CreateSymbolicateCrashLogOptions(
         "--no-crashed-only",
         action="store_false",
         dest="crashed_only",
-        help="do not symbolicate the crashed thread",
+        help="in batch mode, symbolicate all threads, not only the crashed one",
+        default=False,
     )
     arg_parser.add_argument(
         "--disasm-depth",

[JDevlieghere]

Since we're already using argparse, can we use the BooleanOptionalAction to make this work automatically with the affirmative option? https://docs.python.org/3.9/library/argparse.html#action

[medismailben]

Since we're already using argparse, can we use the BooleanOptionalAction to make this work automatically with the affirmative option? https://docs.python.org/3.9/library/argparse.html#action

I did that originally but I had to comment it out in 446abb5 because some testbot didn't satisfy the minimal python version requirement for BooleanOptionalAction. We could revert that commit and see if it breaks any bot.