diff --git a/llvm/lib/Option/OptTable.cpp b/llvm/lib/Option/OptTable.cpp index b8b6b90c253f23..3eceb0fbdfc47b 100644 --- a/llvm/lib/Option/OptTable.cpp +++ b/llvm/lib/Option/OptTable.cpp @@ -197,7 +197,7 @@ OptTable::suggestValueCompletions(StringRef Option, StringRef Arg) const { std::vector Result; for (StringRef Val : Candidates) - if (Val.starts_with(Arg) && Arg.compare(Val)) + if (Val.starts_with(Arg) && Arg != Val) Result.push_back(std::string(Val)); return Result; } diff --git a/llvm/lib/ProfileData/InstrProfCorrelator.cpp b/llvm/lib/ProfileData/InstrProfCorrelator.cpp index cf80a58f43bd90..44e2aeb00d8cc8 100644 --- a/llvm/lib/ProfileData/InstrProfCorrelator.cpp +++ b/llvm/lib/ProfileData/InstrProfCorrelator.cpp @@ -350,16 +350,14 @@ void DwarfInstrProfCorrelator::correlateProfileDataImpl( continue; } StringRef AnnotationName = *AnnotationNameOrErr; - if (AnnotationName.compare( - InstrProfCorrelator::FunctionNameAttributeName) == 0) { + if (AnnotationName == InstrProfCorrelator::FunctionNameAttributeName) { if (auto EC = AnnotationFormValue->getAsCString().moveInto(FunctionName)) consumeError(std::move(EC)); - } else if (AnnotationName.compare( - InstrProfCorrelator::CFGHashAttributeName) == 0) { + } else if (AnnotationName == InstrProfCorrelator::CFGHashAttributeName) { CFGHash = AnnotationFormValue->getAsUnsignedConstant(); - } else if (AnnotationName.compare( - InstrProfCorrelator::NumCountersAttributeName) == 0) { + } else if (AnnotationName == + InstrProfCorrelator::NumCountersAttributeName) { NumCounters = AnnotationFormValue->getAsUnsignedConstant(); } } diff --git a/llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp b/llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp index 727e4e584c053f..f4daab7d06eb53 100644 --- a/llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp +++ b/llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp @@ -171,9 +171,9 @@ getArgAccessQual(const Function &F, unsigned ArgIdx) { if (!ArgAttribute) return SPIRV::AccessQualifier::ReadWrite; - if (ArgAttribute->getString().compare("read_only") == 0) + if (ArgAttribute->getString() == "read_only") return SPIRV::AccessQualifier::ReadOnly; - if (ArgAttribute->getString().compare("write_only") == 0) + if (ArgAttribute->getString() == "write_only") return SPIRV::AccessQualifier::WriteOnly; return SPIRV::AccessQualifier::ReadWrite; } @@ -181,7 +181,7 @@ getArgAccessQual(const Function &F, unsigned ArgIdx) { static std::vector getKernelArgTypeQual(const Function &F, unsigned ArgIdx) { MDString *ArgAttribute = getOCLKernelArgTypeQual(F, ArgIdx); - if (ArgAttribute && ArgAttribute->getString().compare("volatile") == 0) + if (ArgAttribute && ArgAttribute->getString() == "volatile") return {SPIRV::Decoration::Volatile}; return {}; } diff --git a/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp b/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp index 62b4a9278954ce..6623106109316b 100644 --- a/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp +++ b/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp @@ -1802,7 +1802,7 @@ bool X86AsmParser::ParseIntelNamedOperator(StringRef Name, bool &ParseError, SMLoc &End) { // A named operator should be either lower or upper case, but not a mix... // except in MASM, which uses full case-insensitivity. - if (Name.compare(Name.lower()) && Name.compare(Name.upper()) && + if (Name != Name.lower() && Name != Name.upper() && !getParser().isParsingMasm()) return false; if (Name.equals_insensitive("not")) {